[PATCH 1/4] qemu: validate: Drop tpm-tis arch validation

Cole Robinson posted 4 patches 3 years, 7 months ago
[PATCH 1/4] qemu: validate: Drop tpm-tis arch validation
Posted by Cole Robinson 3 years, 7 months ago
Checking against qemu capabilities should be enough here

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/321

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/qemu/qemu_validate.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index f8aa83c1cb..db47fcaa9c 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -4798,12 +4798,6 @@ qemuValidateDomainDeviceDefTPM(virDomainTPMDef *tpm,
 
     switch (tpm->model) {
     case VIR_DOMAIN_TPM_MODEL_TIS:
-        if (!ARCH_IS_X86(def->os.arch) && (def->os.arch != VIR_ARCH_AARCH64)) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("TPM model '%s' is only available for x86 and aarch64 guests"),
-                          virDomainTPMModelTypeToString(tpm->model));
-            return -1;
-        }
         flag = QEMU_CAPS_DEVICE_TPM_TIS;
         break;
     case VIR_DOMAIN_TPM_MODEL_CRB:
-- 
2.36.1
Re: [PATCH 1/4] qemu: validate: Drop tpm-tis arch validation
Posted by Cole Robinson 3 years, 7 months ago
On 6/18/22 2:32 PM, Cole Robinson wrote:
> Checking against qemu capabilities should be enough here
> 
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/321
>

Should be https://gitlab.com/libvirt/libvirt/-/issues/329

I've fixed locally