Fix regression in 'startupPolicy' validation for block disks

[PATCH 0/4] Fix regression in 'startupPolicy' validation for block disks

Peter Krempa posted 4 patches 1 year, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1655209670.git.pkrempa@redhat.com

src/conf/domain_conf.c     | 12 +++++-----
src/conf/domain_validate.c | 49 ++++++++++++++++++++++++--------------
src/conf/domain_validate.h |  2 ++
src/libvirt_private.syms   |  1 +
4 files changed, 40 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/4] Fix regression in 'startupPolicy' validation for block disks

Posted by Peter Krempa 1 year, 10 months ago

Patch 4/4 fixes the regression. Patch 3/4 fixes missing cases in the
validation. Rest of the series is preparation/cleanup.

Peter Krempa (4):
  virDomainDiskDefValidate: Improve error messages for 'startupPolicy'
    checks
  domain_validate: Split out validation of disk startup policy
  virDomainDiskDefValidateStartupPolicy: Validate disk type better
  virDomainDiskTranslateSourcePool: Fix check of 'startupPolicy'
    definition

 src/conf/domain_conf.c     | 12 +++++-----
 src/conf/domain_validate.c | 49 ++++++++++++++++++++++++--------------
 src/conf/domain_validate.h |  2 ++
 src/libvirt_private.syms   |  1 +
 4 files changed, 40 insertions(+), 24 deletions(-)

-- 
2.36.1

Re: [PATCH 0/4] Fix regression in 'startupPolicy' validation for block disks

Posted by Jano Tomko 1 year, 10 months ago

On a Tuesday in June Peter Krempa <pkrempa@redhat.com> wrote:
>
> Patch 4/4 fixes the regression. Patch 3/4 fixes missing cases in the
> validation. Rest of the series is preparation/cleanup.
>
> Peter Krempa (4):
>   virDomainDiskDefValidate: Improve error messages for 'startupPolicy'
>     checks
>   domain_validate: Split out validation of disk startup policy
>   virDomainDiskDefValidateStartupPolicy: Validate disk type better
>   virDomainDiskTranslateSourcePool: Fix check of 'startupPolicy'
>     definition
>
>  src/conf/domain_conf.c     | 12 +++++-----
>  src/conf/domain_validate.c | 49 ++++++++++++++++++++++++--------------
>  src/conf/domain_validate.h |  2 ++
>  src/libvirt_private.syms   |  1 +
>  4 files changed, 40 insertions(+), 24 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

> --
> 2.36.1
>