[v2] Add support for post-copy recovery

[libvirt PATCH v2 60/81] qemu: Use autoptr for mig in qemuMigrationDstPrepareFresh

Posted by Jiri Denemark 3 years, 8 months ago

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---

Notes:
    Version 2:
    - replaces [62/80] qemu: Simplify cleanup in
      qemuMigrationDstPrepareFresh
    - it's the same patch with different commit message and changes touching
      origErr removed :-)

 src/qemu/qemu_migration.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 53236b7239..e888384570 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -3299,7 +3299,7 @@ qemuMigrationDstPrepareFresh(virQEMUDriver *driver,
     virErrorPtr origErr;
     int ret = -1;
     qemuDomainObjPrivate *priv = NULL;
-    qemuMigrationCookie *mig = NULL;
+    g_autoptr(qemuMigrationCookie) mig = NULL;
     g_autofree char *xmlout = NULL;
     unsigned int cookieFlags = 0;
     bool taint_hook = false;
@@ -3451,7 +3451,6 @@ qemuMigrationDstPrepareFresh(virQEMUDriver *driver,
         qemuDomainRemoveInactive(driver, vm);
     }
     virDomainObjEndAPI(&vm);
-    qemuMigrationCookieFree(mig);
     virErrorRestore(&origErr);
     return ret;
 
-- 
2.35.1

Re: [libvirt PATCH v2 60/81] qemu: Use autoptr for mig in qemuMigrationDstPrepareFresh

Posted by Ján Tomko 3 years, 8 months ago

On a Wednesday in 2022, Jiri Denemark wrote:
>Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
>---
>
>Notes:
>    Version 2:
>    - replaces [62/80] qemu: Simplify cleanup in
>      qemuMigrationDstPrepareFresh
>    - it's the same patch with different commit message and changes touching
>      origErr removed :-)
>
> src/qemu/qemu_migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano