[PATCH 00/10] virclosecallbacks: Cleanups (part 1)

Peter Krempa posted 10 patches 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1652790229.git.pkrempa@redhat.com
src/bhyve/bhyve_domain.c           |  8 ++++++--
src/bhyve/bhyve_domain.h           |  2 ++
src/bhyve/bhyve_driver.c           |  2 +-
src/bhyve/bhyve_process.c          |  6 +++---
src/hypervisor/virclosecallbacks.c |  5 ++---
src/hypervisor/virclosecallbacks.h | 29 +++++++++++++++++------------
src/lxc/lxc_domain.c               |  4 +++-
src/lxc/lxc_domain.h               |  1 +
src/lxc/lxc_driver.c               |  2 +-
src/lxc/lxc_process.c              |  8 +++-----
src/qemu/qemu_driver.c             |  2 +-
src/qemu/qemu_migration.c          | 13 +++++--------
src/qemu/qemu_process.c            |  5 ++---
src/util/virobject.h               |  2 +-
14 files changed, 48 insertions(+), 41 deletions(-)
[PATCH 00/10] virclosecallbacks: Cleanups (part 1)
Posted by Peter Krempa 1 year, 11 months ago
This series simplifies some aspects of close callbacks in preparation of
further refactors.

Peter Krempa (10):
  virclosecallbacks.h: Reformat header to contemporary style
  virObjectLockGuard: Require that returned value is used
  qemuMigrationSrcBegin: Automatically free 'xml' variable on error
  bhyve: Store 'driver' in VM private data
  lxc: Store 'driver' in VM private data
  qemuMigrationSrcCleanup: Use 'driver' from VM private data
  qemuProcessAutoDestroy: Use 'driver' from VM private data
  lxcProcessAutoDestroy: Use 'driver' from VM private data
  bhyveProcessAutoDestroy: Use 'driver' from VM private data
  virclosecallbacks: Don't pass opqaue pointer to callback invocation

 src/bhyve/bhyve_domain.c           |  8 ++++++--
 src/bhyve/bhyve_domain.h           |  2 ++
 src/bhyve/bhyve_driver.c           |  2 +-
 src/bhyve/bhyve_process.c          |  6 +++---
 src/hypervisor/virclosecallbacks.c |  5 ++---
 src/hypervisor/virclosecallbacks.h | 29 +++++++++++++++++------------
 src/lxc/lxc_domain.c               |  4 +++-
 src/lxc/lxc_domain.h               |  1 +
 src/lxc/lxc_driver.c               |  2 +-
 src/lxc/lxc_process.c              |  8 +++-----
 src/qemu/qemu_driver.c             |  2 +-
 src/qemu/qemu_migration.c          | 13 +++++--------
 src/qemu/qemu_process.c            |  5 ++---
 src/util/virobject.h               |  2 +-
 14 files changed, 48 insertions(+), 41 deletions(-)

-- 
2.35.3
Re: [PATCH 00/10] virclosecallbacks: Cleanups (part 1)
Posted by Ján Tomko 1 year, 11 months ago
On a Tuesday in 2022, Peter Krempa wrote:
>This series simplifies some aspects of close callbacks in preparation of
>further refactors.
>
>Peter Krempa (10):
>  virclosecallbacks.h: Reformat header to contemporary style
>  virObjectLockGuard: Require that returned value is used
>  qemuMigrationSrcBegin: Automatically free 'xml' variable on error
>  bhyve: Store 'driver' in VM private data
>  lxc: Store 'driver' in VM private data
>  qemuMigrationSrcCleanup: Use 'driver' from VM private data
>  qemuProcessAutoDestroy: Use 'driver' from VM private data
>  lxcProcessAutoDestroy: Use 'driver' from VM private data
>  bhyveProcessAutoDestroy: Use 'driver' from VM private data
>  virclosecallbacks: Don't pass opqaue pointer to callback invocation
>
> src/bhyve/bhyve_domain.c           |  8 ++++++--
> src/bhyve/bhyve_domain.h           |  2 ++
> src/bhyve/bhyve_driver.c           |  2 +-
> src/bhyve/bhyve_process.c          |  6 +++---
> src/hypervisor/virclosecallbacks.c |  5 ++---
> src/hypervisor/virclosecallbacks.h | 29 +++++++++++++++++------------
> src/lxc/lxc_domain.c               |  4 +++-
> src/lxc/lxc_domain.h               |  1 +
> src/lxc/lxc_driver.c               |  2 +-
> src/lxc/lxc_process.c              |  8 +++-----
> src/qemu/qemu_driver.c             |  2 +-
> src/qemu/qemu_migration.c          | 13 +++++--------
> src/qemu/qemu_process.c            |  5 ++---
> src/util/virobject.h               |  2 +-
> 14 files changed, 48 insertions(+), 41 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano