qemu: fd: Address differences between FD passing types

[PATCH 0/9] qemu: fd: Address differences between FD passing types

Peter Krempa posted 9 patches 1 year, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1652778351.git.pkrempa@redhat.com

src/qemu/qemu_command.c      |  55 +++-----
src/qemu/qemu_domain.c       |   7 +-
src/qemu/qemu_domain.h       |   7 +-
src/qemu/qemu_fd.c           | 265 ++++++++++++++++++++---------------
src/qemu/qemu_fd.h           |  24 +++-
src/qemu/qemu_hotplug.c      |  15 +-
src/qemu/qemu_interface.c    |   8 +-
src/qemu/qemu_monitor_json.c |   4 +-
src/qemu/qemu_process.c      |   5 +-
src/qemu/qemu_slirp.c        |   4 +-
tests/qemuxml2argvmock.c     |  10 +-
tests/testutilsqemu.c        |  26 ++--
12 files changed, 232 insertions(+), 198 deletions(-)

Expand all Fold all

[PATCH 0/9] qemu: fd: Address differences between FD passing types

Posted by Peter Krempa 1 year, 11 months ago

Originally the intention was to have one set of helpers but it turned
out to be too much hassle and too obscure semantics.

This series adds a new helper qemuFDPassDirect and simplifies the
internals greatly by using a distinct set of APIs.

Peter Krempa (9):
  qemu: fd: Add a distinct set of APIs for 'direct' fd passing mode
  qemu: Convert passing of 'vhostfd' to 'qemuFDPassDirect'
  qemu: Convert passing of 'tapfds' to 'qemuFDPassDirect'
  qemu: Convert passing of 'slirpfd' to 'qemuFDPassDirect'
  qemu: Use 'qemuFDPassDirect' for 'unix' chardevs
  qemuFDPassValidate: Don't validate file descriptors
  qemu: fd: Remove support for 'direct' fd passing from 'qemuFDPass'
  qemuFDPassTransferCommand: Remove return value
  qemu: fd: Fix documentation for FD set related functions

 src/qemu/qemu_command.c      |  55 +++-----
 src/qemu/qemu_domain.c       |   7 +-
 src/qemu/qemu_domain.h       |   7 +-
 src/qemu/qemu_fd.c           | 265 ++++++++++++++++++++---------------
 src/qemu/qemu_fd.h           |  24 +++-
 src/qemu/qemu_hotplug.c      |  15 +-
 src/qemu/qemu_interface.c    |   8 +-
 src/qemu/qemu_monitor_json.c |   4 +-
 src/qemu/qemu_process.c      |   5 +-
 src/qemu/qemu_slirp.c        |   4 +-
 tests/qemuxml2argvmock.c     |  10 +-
 tests/testutilsqemu.c        |  26 ++--
 12 files changed, 232 insertions(+), 198 deletions(-)

-- 
2.35.3

Re: [PATCH 0/9] qemu: fd: Address differences between FD passing types

Posted by Ján Tomko 1 year, 11 months ago

On a Tuesday in 2022, Peter Krempa wrote:
>Originally the intention was to have one set of helpers but it turned
>out to be too much hassle and too obscure semantics.
>
>This series adds a new helper qemuFDPassDirect and simplifies the
>internals greatly by using a distinct set of APIs.
>
>Peter Krempa (9):
>  qemu: fd: Add a distinct set of APIs for 'direct' fd passing mode
>  qemu: Convert passing of 'vhostfd' to 'qemuFDPassDirect'
>  qemu: Convert passing of 'tapfds' to 'qemuFDPassDirect'
>  qemu: Convert passing of 'slirpfd' to 'qemuFDPassDirect'
>  qemu: Use 'qemuFDPassDirect' for 'unix' chardevs
>  qemuFDPassValidate: Don't validate file descriptors
>  qemu: fd: Remove support for 'direct' fd passing from 'qemuFDPass'
>  qemuFDPassTransferCommand: Remove return value
>  qemu: fd: Fix documentation for FD set related functions
>
> src/qemu/qemu_command.c      |  55 +++-----
> src/qemu/qemu_domain.c       |   7 +-
> src/qemu/qemu_domain.h       |   7 +-
> src/qemu/qemu_fd.c           | 265 ++++++++++++++++++++---------------
> src/qemu/qemu_fd.h           |  24 +++-
> src/qemu/qemu_hotplug.c      |  15 +-
> src/qemu/qemu_interface.c    |   8 +-
> src/qemu/qemu_monitor_json.c |   4 +-
> src/qemu/qemu_process.c      |   5 +-
> src/qemu/qemu_slirp.c        |   4 +-
> tests/qemuxml2argvmock.c     |  10 +-
> tests/testutilsqemu.c        |  26 ++--
> 12 files changed, 232 insertions(+), 198 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano