[PATCH 00/11] Clean up arguments for qemuBuildCommandLine

Peter Krempa posted 11 patches 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1652710341.git.pkrempa@redhat.com
docs/drvqemu.rst         | 14 +++++--
src/libvirt-domain.c     |  7 ++++
src/qemu/qemu_command.c  | 85 ++++++++++++----------------------------
src/qemu/qemu_command.h  | 23 ++++-------
src/qemu/qemu_conf.h     |  1 +
src/qemu/qemu_driver.c   | 37 +++++++++--------
src/qemu/qemu_hotplug.c  |  2 +-
src/qemu/qemu_process.c  | 24 +++---------
src/qemu/qemu_process.h  |  7 +---
tests/qemuxml2argvtest.c | 10 ++---
10 files changed, 82 insertions(+), 128 deletions(-)
[PATCH 00/11] Clean up arguments for qemuBuildCommandLine
Posted by Peter Krempa 1 year, 11 months ago
This series cleans up the arguments.

Note that patches 10,11 can be dropped if we decide that we want to keep
the '-S' argument off the command line bulit for 'virsh
domxml-to-native' for qemu definitions.

Peter Krempa (11):
  virConnectDomainXMLToNative: Add note about dynamically configured
    features
  docs: drvqemu: Decrease expectations about command line from 'virsh
    domxml-to-native'
  qemu: command: Don't hide 'vhost' fds from 'standalone' command line
  qemuBuildCommandLine: Convert 'standalone' flag to use 'flags'
  qemu: Store state of FIPS in virQEMUDriver
  qemuBuildCommandLine: Sanitize debug logging
  qemuConnectDomainXMLToNative: Refactor cleanup
  qemuBuildCommandLine: Remove 'driver' argument
  qemuBuildCommandLine: Inline qemuCheckFips
  qemuBuildCommandLine: Don't avoid '-S' flag for 'domxml-to-native'
    conversion
  qemuBuildCommandLine: Remove 'flags' argument

 docs/drvqemu.rst         | 14 +++++--
 src/libvirt-domain.c     |  7 ++++
 src/qemu/qemu_command.c  | 85 ++++++++++++----------------------------
 src/qemu/qemu_command.h  | 23 ++++-------
 src/qemu/qemu_conf.h     |  1 +
 src/qemu/qemu_driver.c   | 37 +++++++++--------
 src/qemu/qemu_hotplug.c  |  2 +-
 src/qemu/qemu_process.c  | 24 +++---------
 src/qemu/qemu_process.h  |  7 +---
 tests/qemuxml2argvtest.c | 10 ++---
 10 files changed, 82 insertions(+), 128 deletions(-)

-- 
2.35.3
Re: [PATCH 00/11] Clean up arguments for qemuBuildCommandLine
Posted by Pavel Hrdina 1 year, 11 months ago
On Mon, May 16, 2022 at 05:12:30PM +0200, Peter Krempa wrote:
> This series cleans up the arguments.
> 
> Note that patches 10,11 can be dropped if we decide that we want to keep
> the '-S' argument off the command line bulit for 'virsh
> domxml-to-native' for qemu definitions.
> 
> Peter Krempa (11):
>   virConnectDomainXMLToNative: Add note about dynamically configured
>     features
>   docs: drvqemu: Decrease expectations about command line from 'virsh
>     domxml-to-native'
>   qemu: command: Don't hide 'vhost' fds from 'standalone' command line
>   qemuBuildCommandLine: Convert 'standalone' flag to use 'flags'
>   qemu: Store state of FIPS in virQEMUDriver
>   qemuBuildCommandLine: Sanitize debug logging
>   qemuConnectDomainXMLToNative: Refactor cleanup
>   qemuBuildCommandLine: Remove 'driver' argument
>   qemuBuildCommandLine: Inline qemuCheckFips
>   qemuBuildCommandLine: Don't avoid '-S' flag for 'domxml-to-native'
>     conversion
>   qemuBuildCommandLine: Remove 'flags' argument

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

I'm OK with patches 10,11 as well so unless somebody else objects apply
the RB to these patches too.