testutils*: Hide some global variables

[PATCH 0/2] testutils*: Hide some global variables

Michal Privoznik posted 2 patches 1 year, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1651820156.git.mprivozn@redhat.com

tests/qemuxml2argvtest.c |  4 ++--
tests/testutils.c        |  7 ++++++-
tests/testutils.h        |  2 +-
tests/testutilsqemu.c    | 24 +++++++++++++++++++-----
tests/testutilsqemu.h    | 13 +++++++++----
5 files changed, 37 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCH 0/2] testutils*: Hide some global variables

Posted by Michal Privoznik 1 year, 11 months ago

Pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/532708775

Michal Prívozník (2):
  testutils: Write setter for virTestHostArch global variable
  testutilsqemu: Write getter/setter for CPU def global variables

 tests/qemuxml2argvtest.c |  4 ++--
 tests/testutils.c        |  7 ++++++-
 tests/testutils.h        |  2 +-
 tests/testutilsqemu.c    | 24 +++++++++++++++++++-----
 tests/testutilsqemu.h    | 13 +++++++++----
 5 files changed, 37 insertions(+), 13 deletions(-)

-- 
2.35.1

Re: [PATCH 0/2] testutils*: Hide some global variables

Posted by Daniel P. Berrangé 1 year, 11 months ago

On Fri, May 06, 2022 at 08:59:25AM +0200, Michal Privoznik wrote:
> Pipeline:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/532708775
> 
> Michal Prívozník (2):
>   testutils: Write setter for virTestHostArch global variable
>   testutilsqemu: Write getter/setter for CPU def global variables

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|