[PATCH 00/12] lib: Use virXMLProp*() more

Michal Privoznik posted 12 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1642771641.git.mprivozn@redhat.com
src/bhyve/bhyve_command.c                     |   2 +-
src/conf/cpu_conf.c                           |  76 +--
src/conf/cpu_conf.h                           |   2 +-
src/conf/domain_conf.c                        | 637 +++++++-----------
src/conf/domain_conf.h                        |  63 +-
src/conf/network_conf.c                       | 116 +---
src/conf/network_conf.h                       |  12 +-
src/conf/storage_conf.c                       |  17 +-
src/conf/storage_source_conf.c                |  14 +-
src/conf/storage_source_conf.h                |   2 +-
src/conf/virnetworkportdef.c                  |  51 +-
src/conf/virnetworkportdef.h                  |   6 +-
src/cpu/cpu_x86.c                             |  58 +-
src/libxl/libxl_conf.c                        |   2 +
src/libxl/xen_xl.c                            |   2 +
src/libxl/xen_xm.c                            |   2 +
src/lxc/lxc_container.c                       |   3 +
src/qemu/qemu_capabilities.c                  |  28 +-
src/qemu/qemu_command.c                       |  12 +-
src/qemu/qemu_domain.c                        |  16 +-
src/qemu/qemu_domain_address.c                |   2 +-
src/qemu/qemu_hostdev.c                       |   4 +-
src/qemu/qemu_hotplug.c                       |   3 +-
src/qemu/qemu_process.c                       |   2 +-
src/qemu/qemu_validate.c                      |   8 +-
src/security/virt-aa-helper.c                 |   2 +-
src/util/virxml.c                             |   4 +-
src/vz/vz_sdk.c                               |   4 +-
.../qemuxml2argvdata/vhost_queues-invalid.err |   2 +-
29 files changed, 426 insertions(+), 726 deletions(-)
[PATCH 00/12] lib: Use virXMLProp*() more
Posted by Michal Privoznik 2 years, 3 months ago
*** BLURB HERE ***

Michal Prívozník (12):
  virxml: Extend virXMLPropU{Int,LongLong}() error message
  virNetworkPortDefParseXML: Fix a typo in an error message
  qemuValidateDomainDeviceDefFS: Use correct enum for fs->multidevs
    comparison
  qemu: Use virTristateBool instead of virTristateSwitch in a few places
  lib: Eliminate use of virTristateSwitchTypeFromString()
  lib: Almost eliminate use of virTristateBoolTypeFromString()
  conf: Convert virCPUDefParseXML() to virXMLProp*()
  conf: Convert virDomainDefParseBootXML() to virXMLProp*()
  conf: Convert virDomainFSDefParseXML() to virXMLProp*()
  conf: Convert virDomainNetDefParseXML() to virXMLProp*()
  conf: Convert virNetworkPortDefParseXML() to virXMLProp*()
  conf: Convert virDomainHostdevDefParseXMLSubsys() to virXMLProp*()

 src/bhyve/bhyve_command.c                     |   2 +-
 src/conf/cpu_conf.c                           |  76 +--
 src/conf/cpu_conf.h                           |   2 +-
 src/conf/domain_conf.c                        | 637 +++++++-----------
 src/conf/domain_conf.h                        |  63 +-
 src/conf/network_conf.c                       | 116 +---
 src/conf/network_conf.h                       |  12 +-
 src/conf/storage_conf.c                       |  17 +-
 src/conf/storage_source_conf.c                |  14 +-
 src/conf/storage_source_conf.h                |   2 +-
 src/conf/virnetworkportdef.c                  |  51 +-
 src/conf/virnetworkportdef.h                  |   6 +-
 src/cpu/cpu_x86.c                             |  58 +-
 src/libxl/libxl_conf.c                        |   2 +
 src/libxl/xen_xl.c                            |   2 +
 src/libxl/xen_xm.c                            |   2 +
 src/lxc/lxc_container.c                       |   3 +
 src/qemu/qemu_capabilities.c                  |  28 +-
 src/qemu/qemu_command.c                       |  12 +-
 src/qemu/qemu_domain.c                        |  16 +-
 src/qemu/qemu_domain_address.c                |   2 +-
 src/qemu/qemu_hostdev.c                       |   4 +-
 src/qemu/qemu_hotplug.c                       |   3 +-
 src/qemu/qemu_process.c                       |   2 +-
 src/qemu/qemu_validate.c                      |   8 +-
 src/security/virt-aa-helper.c                 |   2 +-
 src/util/virxml.c                             |   4 +-
 src/vz/vz_sdk.c                               |   4 +-
 .../qemuxml2argvdata/vhost_queues-invalid.err |   2 +-
 29 files changed, 426 insertions(+), 726 deletions(-)

-- 
2.34.1

Re: [PATCH 00/12] lib: Use virXMLProp*() more
Posted by Ján Tomko 2 years, 3 months ago
On a Friday in 2022, Michal Privoznik wrote:
>*** BLURB HERE ***
>
>Michal Prívozník (12):
>  virxml: Extend virXMLPropU{Int,LongLong}() error message
>  virNetworkPortDefParseXML: Fix a typo in an error message
>  qemuValidateDomainDeviceDefFS: Use correct enum for fs->multidevs
>    comparison
>  qemu: Use virTristateBool instead of virTristateSwitch in a few places
>  lib: Eliminate use of virTristateSwitchTypeFromString()
>  lib: Almost eliminate use of virTristateBoolTypeFromString()
>  conf: Convert virCPUDefParseXML() to virXMLProp*()
>  conf: Convert virDomainDefParseBootXML() to virXMLProp*()
>  conf: Convert virDomainFSDefParseXML() to virXMLProp*()
>  conf: Convert virDomainNetDefParseXML() to virXMLProp*()
>  conf: Convert virNetworkPortDefParseXML() to virXMLProp*()
>  conf: Convert virDomainHostdevDefParseXMLSubsys() to virXMLProp*()
>
> src/bhyve/bhyve_command.c                     |   2 +-
> src/conf/cpu_conf.c                           |  76 +--
> src/vz/vz_sdk.c                               |   4 +-
[..]
> .../qemuxml2argvdata/vhost_queues-invalid.err |   2 +-
> 29 files changed, 426 insertions(+), 726 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano