util: openvswitch: cleanup

[libvirt PATCH 0/6] util: openvswitch: cleanup

Ján Tomko posted 6 patches 2 years, 3 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1642437534.git.jtomko@redhat.com

src/libvirt_private.syms        |   2 -
src/util/virnetdevopenvswitch.c | 406 +++++++++++++++++---------------
src/util/virnetdevopenvswitch.h |   7 -
3 files changed, 213 insertions(+), 202 deletions(-)

Expand all Fold all

[libvirt PATCH 0/6] util: openvswitch: cleanup

Posted by Ján Tomko 2 years, 3 months ago

Rearrange some code and remove 'cmd' variable reuse to get rid of
manual 'virCommandFree' in functions using g_auto.

Ján Tomko (6):
  util: openvswitch: move InterfaceClear{Rx,Tx}Qos
  util: openvswitch: unexport InterfaceClear{Rx,Tx}Qos
  util: openvswitch: split out virNetDevOpenvswitchInterfaceSetTxQos
  util: openvswitch: split out virNetDevOpenvswitchInterfaceSetRxQos
  util: openvswitch: do not reuse cmd in InterfaceSetTxQos
  util: openvswitch: do not reuse cmd in InterfaceClearTxQos

 src/libvirt_private.syms        |   2 -
 src/util/virnetdevopenvswitch.c | 406 +++++++++++++++++---------------
 src/util/virnetdevopenvswitch.h |   7 -
 3 files changed, 213 insertions(+), 202 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/6] util: openvswitch: cleanup

Posted by Michal Prívozník 2 years, 3 months ago

On 1/17/22 17:40, Ján Tomko wrote:
> Rearrange some code and remove 'cmd' variable reuse to get rid of
> manual 'virCommandFree' in functions using g_auto.
> 
> Ján Tomko (6):
>   util: openvswitch: move InterfaceClear{Rx,Tx}Qos
>   util: openvswitch: unexport InterfaceClear{Rx,Tx}Qos
>   util: openvswitch: split out virNetDevOpenvswitchInterfaceSetTxQos
>   util: openvswitch: split out virNetDevOpenvswitchInterfaceSetRxQos
>   util: openvswitch: do not reuse cmd in InterfaceSetTxQos
>   util: openvswitch: do not reuse cmd in InterfaceClearTxQos
> 
>  src/libvirt_private.syms        |   2 -
>  src/util/virnetdevopenvswitch.c | 406 +++++++++++++++++---------------
>  src/util/virnetdevopenvswitch.h |   7 -
>  3 files changed, 213 insertions(+), 202 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal