Fix creation of snapshots without libvirt metadata

[PATCH for 8.0 0/3] Fix creation of snapshots without libvirt metadata

Peter Krempa posted 3 patches 2 years, 3 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1641894644.git.pkrempa@redhat.com

src/conf/virdomainmomentobjlist.c |   4 +-
src/conf/virdomainmomentobjlist.h | 121 +++++++++++++++++++-----------
src/libvirt_private.syms          |   2 +
src/qemu/qemu_snapshot.c          |  25 +++---
4 files changed, 97 insertions(+), 55 deletions(-)

Expand all Fold all

[PATCH for 8.0 0/3] Fix creation of snapshots without libvirt metadata

Posted by Peter Krempa 2 years, 3 months ago

After a recent unreleased refactor we don't remove the temporary
snapshot object from the list when finishing a snapshot without metadata
thus we should fix it before releasing a buggy release.

This patchset fixes it by not adding it into the list in the first
place.

Peter Krempa (3):
  virdomainmomentobjlist.h: Convert to modern header style
  conf: moment: Export helpers to create the virDomainMoment wrapper
  qemuSnapshotCreate: Don't insert snapshot into list with
    VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA

 src/conf/virdomainmomentobjlist.c |   4 +-
 src/conf/virdomainmomentobjlist.h | 121 +++++++++++++++++++-----------
 src/libvirt_private.syms          |   2 +
 src/qemu/qemu_snapshot.c          |  25 +++---
 4 files changed, 97 insertions(+), 55 deletions(-)

-- 
2.31.1

Re: [PATCH for 8.0 0/3] Fix creation of snapshots without libvirt metadata

Posted by Michal Prívozník 2 years, 3 months ago

On 1/11/22 10:53, Peter Krempa wrote:
> After a recent unreleased refactor we don't remove the temporary
> snapshot object from the list when finishing a snapshot without metadata
> thus we should fix it before releasing a buggy release.
> 
> This patchset fixes it by not adding it into the list in the first
> place.
> 
> Peter Krempa (3):
>   virdomainmomentobjlist.h: Convert to modern header style
>   conf: moment: Export helpers to create the virDomainMoment wrapper
>   qemuSnapshotCreate: Don't insert snapshot into list with
>     VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA
> 
>  src/conf/virdomainmomentobjlist.c |   4 +-
>  src/conf/virdomainmomentobjlist.h | 121 +++++++++++++++++++-----------
>  src/libvirt_private.syms          |   2 +
>  src/qemu/qemu_snapshot.c          |  25 +++---
>  4 files changed, 97 insertions(+), 55 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal