[PATCH 1/8] util: Report error in virLogParseDefaultPriority

Martin Kletzander posted 8 patches 4 years, 1 month ago
[PATCH 1/8] util: Report error in virLogParseDefaultPriority
Posted by Martin Kletzander 4 years, 1 month ago
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/util/virlog.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/util/virlog.c b/src/util/virlog.c
index ac35e36148c6..90d3d7c5cb53 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -1187,6 +1187,10 @@ virLogParseDefaultPriority(const char *priority)
         return VIR_LOG_WARN;
     else if (STREQ(priority, "4") || STREQ(priority, "error"))
         return VIR_LOG_ERROR;
+
+    virReportError(VIR_ERR_INVALID_ARG,
+                   _("Failed to set logging priority, argument '%s' is "
+                     "invalid"), priority);
     return -1;
 }
 
-- 
2.34.1

Re: [PATCH 1/8] util: Report error in virLogParseDefaultPriority
Posted by Erik Skultety 4 years, 1 month ago
On Tue, Jan 04, 2022 at 02:47:05PM +0100, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>