use g_auto for virCommand (Episode I: The End)

[libvirt PATCH 00/14] use g_auto for virCommand (Episode I: The End)

Ján Tomko posted 14 patches 2 years, 4 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1639403837.git.jtomko@redhat.com

src/bhyve/bhyve_capabilities.c        | 57 ++++++++++-----------------
src/bhyve/bhyve_command.c             | 36 ++++++++---------
src/bhyve/bhyve_driver.c              | 28 ++++++-------
src/bhyve/bhyve_process.c             | 25 ++++--------
src/lxc/lxc_container.c               |  3 +-
src/lxc/lxc_process.c                 | 14 ++-----
src/qemu/qemu_driver.c                |  3 +-
src/qemu/qemu_interface.c             |  3 +-
src/qemu/qemu_tpm.c                   |  4 +-
src/security/security_apparmor.c      | 15 ++-----
src/storage/storage_backend_logical.c | 18 ++++-----
src/storage/storage_util.c            |  5 +--
12 files changed, 78 insertions(+), 133 deletions(-)

Expand all Fold all

[libvirt PATCH 00/14] use g_auto for virCommand (Episode I: The End)

Posted by Ján Tomko 2 years, 4 months ago

A partial cleanup. The rest is in progress (TM)

Ján Tomko (14):
  bhyve: refactor virBhyveProbeGrubCaps
  bhyve: refactor bhyveProbeCapsDeviceHelper
  bhyve: refactor bhyveProbeCapsFromHelp
  bhyve: refactor bhyveConnectDomainXMLToNative
  bhyve: use g_auto in virBhyveProcessStartImpl
  bhyve: use g_auto in virBhyveProcessStop
  bhyve: refactor virBhyveProcessBuildBhyveCmd
  lxc: use g_auto in lxcContainerChild
  lxc: refactor virLXCProcessBuildControllerCmd
  lxc: use g_auto for virCommand in virLXCProcessEnsureRootFS
  storage: logical: use two cmd vars in GetPoolSources
  storage: util: steal cmd in CreateQemuImgCmdFromVol
  security: apparmor: use automatic cleanup in load_profile
  qemu: use automatic cleanup for virCommand

 src/bhyve/bhyve_capabilities.c        | 57 ++++++++++-----------------
 src/bhyve/bhyve_command.c             | 36 ++++++++---------
 src/bhyve/bhyve_driver.c              | 28 ++++++-------
 src/bhyve/bhyve_process.c             | 25 ++++--------
 src/lxc/lxc_container.c               |  3 +-
 src/lxc/lxc_process.c                 | 14 ++-----
 src/qemu/qemu_driver.c                |  3 +-
 src/qemu/qemu_interface.c             |  3 +-
 src/qemu/qemu_tpm.c                   |  4 +-
 src/security/security_apparmor.c      | 15 ++-----
 src/storage/storage_backend_logical.c | 18 ++++-----
 src/storage/storage_util.c            |  5 +--
 12 files changed, 78 insertions(+), 133 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/14] use g_auto for virCommand (Episode I: The End)

Posted by Michal Prívozník 2 years, 4 months ago

On 12/13/21 14:59, Ján Tomko wrote:
> A partial cleanup. The rest is in progress (TM)
> 
> Ján Tomko (14):
>   bhyve: refactor virBhyveProbeGrubCaps
>   bhyve: refactor bhyveProbeCapsDeviceHelper
>   bhyve: refactor bhyveProbeCapsFromHelp
>   bhyve: refactor bhyveConnectDomainXMLToNative
>   bhyve: use g_auto in virBhyveProcessStartImpl
>   bhyve: use g_auto in virBhyveProcessStop
>   bhyve: refactor virBhyveProcessBuildBhyveCmd
>   lxc: use g_auto in lxcContainerChild
>   lxc: refactor virLXCProcessBuildControllerCmd
>   lxc: use g_auto for virCommand in virLXCProcessEnsureRootFS
>   storage: logical: use two cmd vars in GetPoolSources
>   storage: util: steal cmd in CreateQemuImgCmdFromVol
>   security: apparmor: use automatic cleanup in load_profile
>   qemu: use automatic cleanup for virCommand
> 
>  src/bhyve/bhyve_capabilities.c        | 57 ++++++++++-----------------
>  src/bhyve/bhyve_command.c             | 36 ++++++++---------
>  src/bhyve/bhyve_driver.c              | 28 ++++++-------
>  src/bhyve/bhyve_process.c             | 25 ++++--------
>  src/lxc/lxc_container.c               |  3 +-
>  src/lxc/lxc_process.c                 | 14 ++-----
>  src/qemu/qemu_driver.c                |  3 +-
>  src/qemu/qemu_interface.c             |  3 +-
>  src/qemu/qemu_tpm.c                   |  4 +-
>  src/security/security_apparmor.c      | 15 ++-----
>  src/storage/storage_backend_logical.c | 18 ++++-----
>  src/storage/storage_util.c            |  5 +--
>  12 files changed, 78 insertions(+), 133 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal