On a Thursday in 2021, Peter Krempa wrote:
>In this part I'm cleaning up the command line generators and unifying
>them. Until now there were multiple custom -chardev generators in places
>where it was simpler to use it than the common code. This series fixes
>the common code to have sane API and refactors virtiofs, vhost-user-blk
>vhost-user-gpu and TPM code to use it.
>
>After this series we are left with 3 distinct generators for chardev
>properties:
>
> - commandline
> - commandline for capabilties probing
> - QMP
>
>After the refactors here we can finally also add DO_TEST_CAPS_LATEST
>of chardev tests without actually touching the host as part of the
>testsuite which was impossible before.
>
>In further parts the generators will be put into one place and prepared
>for upcoming qemu refactors.
>
>Peter Krempa (24):
> virDomainDeviceInfoIterateFlags: Export the symbol
> qemu: domain: Introduce helpers for initializing chardev backend of
> devices
> qemu: Move creation and opening of chardev backend FDs to host prepare
> step
> qemu: command: Remove unused QEMU_BUILD_CHARDEV_FILE_LOGD and
> QEMU_BUILD_CHARDEV_UNIX_FD_PASS
> qemu: command: remove the unused 'chardevStdioLogd' argument/variable
> qemu: domain: Refactor chardev definition preparing
> qemu: Store chardev 'wait' flag in chardev source private data
> qemuBuildChrChardevStr: Remove 'cdevflags' argument
> qemuBuildChrChardevStr: Remove unused arguments and clean up callers
> qemuxml2argvtest: Add DO_TEST_CAPS_LATEST versions for all character
> device tests
> qemuxml2argvtest: Add _LATEST version for 'name-escape' case
> qemuBuildConsoleCommandLine: Remove identical code
> qemuBuildChrChardevStr: Directly generate command line
> qemuBuildChardevCommand: Move earlier
> qemuBuildChardevCommand: Don't prefix alias
> qemuBuildChardevCommand: Split creation of the command and setup of
> other objects
> qemu: Store TLS config options for chardevs in
> qemuDomainChrSourcePrivate
> qemuBuildChardevCommand: Remove unused 'cfg' parameter
> qemu: Implement chardev source setup for disk
> qemu: Use qemuBuildChrChardevCommand for vhost-user disk backend
> qemu: Use qemuBuildChrChardevCommand for virtiofs backend chardev
> qemu: Use qemuBuildChrChardevCommand for vhost-user-gpu backend
> chardev
> qemu: Implement chardev source setup for tpm
> qemu: command: Use 'qemuBuildChrChardevCommand' to build TPM backend
>
> 46 files changed, 1959 insertions(+), 776 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano