[PATCH 30/36] libxl_driver: Use automatic memory freeing for virBitmap

Peter Krempa posted 36 patches 4 years, 2 months ago
[PATCH 30/36] libxl_driver: Use automatic memory freeing for virBitmap
Posted by Peter Krempa 4 years, 2 months ago
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libxl/libxl_driver.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 0b14b5093e..ef31f2cdcf 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -2416,7 +2416,7 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu,
     libxlDriverPrivate *driver = dom->conn->privateData;
     libxlDriverConfig *cfg = libxlDriverConfigGet(driver);
     virDomainDef *targetDef = NULL;
-    virBitmap *pcpumap = NULL;
+    g_autoptr(virBitmap) pcpumap = NULL;
     virDomainVcpuDef *vcpuinfo;
     virDomainObj *vm;
     int ret = -1;
@@ -2477,7 +2477,6 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu,

  cleanup:
     virDomainObjEndAPI(&vm);
-    virBitmapFree(pcpumap);
     virObjectUnref(cfg);
     return ret;
 }
@@ -4808,7 +4807,7 @@ libxlDomainGetNumaParameters(virDomainPtr dom,
     libxlDriverConfig *cfg = libxlDriverConfigGet(driver);
     virDomainObj *vm;
     libxl_bitmap nodemap;
-    virBitmap *nodes = NULL;
+    g_autoptr(virBitmap) nodes = NULL;
     int rc, ret = -1;
     size_t i, j;

@@ -4907,7 +4906,6 @@ libxlDomainGetNumaParameters(virDomainPtr dom,
     ret = 0;

  cleanup:
-    virBitmapFree(nodes);
     libxl_bitmap_dispose(&nodemap);
     virDomainObjEndAPI(&vm);
     virObjectUnref(cfg);
-- 
2.31.1

Re: [PATCH 30/36] libxl_driver: Use automatic memory freeing for virBitmap
Posted by Ján Tomko 4 years, 2 months ago
On a Thursday in 2021, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/libxl/libxl_driver.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano