[PATCH v1 0/7] Fix build without XDR library

Michal Privoznik posted 7 patches 2 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1638977134.git.mprivozn@redhat.com
examples/c/admin/meson.build |  36 +++++-----
meson.build                  |  47 ++++++------
src/admin/meson.build        |  36 +++++-----
src/libvirt-stream.c         |   6 +-
src/libvirt_logging.syms     |  18 +++++
src/libvirt_private.syms     |   9 ---
src/libvirt_remote.syms      |  56 ---------------
src/libvirt_socket.syms      |  65 +++++++++++++++++
src/logging/meson.build      |  31 ++++----
src/meson.build              |  98 ++++++++++++-------------
src/rpc/meson.build          | 136 ++++++++++++++++++++---------------
tools/meson.build            |  44 ++++++------
12 files changed, 322 insertions(+), 260 deletions(-)
create mode 100644 src/libvirt_logging.syms
create mode 100644 src/libvirt_socket.syms
[PATCH v1 0/7] Fix build without XDR library
Posted by Michal Privoznik 2 years, 4 months ago
It's not much that's left when no XDR library is found, but some users
might want just stateless drivers.

BTW: there is still one pending issue - if no XDR library is found then
remote driver is turned off which in turn means libvirtd is turned off.
Until here it makes sense. But what I don't understand is why qemu
driver depends on libvirtd, since it has embed mode. Transitively, why
any driver depends on libvird?

Michal Prívozník (7):
  libvirt-stream: Don't require RPC module
  rpc: Separate out socket code into another static lib
  rpc: Build only when XDR is available
  logging: Build log manager only when RPC is available
  admin: Build only when RPC is available
  meson: Require XDR for wireshark
  meson: Detect XDR only when needed

 examples/c/admin/meson.build |  36 +++++-----
 meson.build                  |  47 ++++++------
 src/admin/meson.build        |  36 +++++-----
 src/libvirt-stream.c         |   6 +-
 src/libvirt_logging.syms     |  18 +++++
 src/libvirt_private.syms     |   9 ---
 src/libvirt_remote.syms      |  56 ---------------
 src/libvirt_socket.syms      |  65 +++++++++++++++++
 src/logging/meson.build      |  31 ++++----
 src/meson.build              |  98 ++++++++++++-------------
 src/rpc/meson.build          | 136 ++++++++++++++++++++---------------
 tools/meson.build            |  44 ++++++------
 12 files changed, 322 insertions(+), 260 deletions(-)
 create mode 100644 src/libvirt_logging.syms
 create mode 100644 src/libvirt_socket.syms

-- 
2.32.0

Re: [PATCH v1 0/7] Fix build without XDR library
Posted by Ján Tomko 2 years, 4 months ago
On a Wednesday in 2021, Michal Privoznik wrote:
>It's not much that's left when no XDR library is found, but some users
>might want just stateless drivers.
>
>BTW: there is still one pending issue - if no XDR library is found then
>remote driver is turned off which in turn means libvirtd is turned off.
>Until here it makes sense. But what I don't understand is why qemu
>driver depends on libvirtd, since it has embed mode. Transitively, why
>any driver depends on libvird?
>
>Michal Prívozník (7):
>  libvirt-stream: Don't require RPC module
>  rpc: Separate out socket code into another static lib
>  rpc: Build only when XDR is available
>  logging: Build log manager only when RPC is available
>  admin: Build only when RPC is available
>  meson: Require XDR for wireshark
>  meson: Detect XDR only when needed
>
> examples/c/admin/meson.build |  36 +++++-----
> meson.build                  |  47 ++++++------
> src/admin/meson.build        |  36 +++++-----
> src/libvirt-stream.c         |   6 +-
> src/libvirt_logging.syms     |  18 +++++
> src/libvirt_private.syms     |   9 ---
> src/libvirt_remote.syms      |  56 ---------------
> src/libvirt_socket.syms      |  65 +++++++++++++++++
> src/logging/meson.build      |  31 ++++----
> src/meson.build              |  98 ++++++++++++-------------
> src/rpc/meson.build          | 136 ++++++++++++++++++++---------------
> tools/meson.build            |  44 ++++++------
> 12 files changed, 322 insertions(+), 260 deletions(-)
> create mode 100644 src/libvirt_logging.syms
> create mode 100644 src/libvirt_socket.syms
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano