qemu snapshot revert cleanup and refactor

[libvirt PATCH 00/14] qemu snapshot revert cleanup and refactor

Posted by Pavel Hrdina 2 years, 4 months ago

Pavel Hrdina (14):
  qemu_snapshot: revert: fix incorrect jump to cleanup
  qemu_snapshot: revert: drop unused variable
  qemu_snapshot: revert: use g_autoptr
  qemu_snapshot: revert: jump to endjob instead of calling
    qemuProcessEndJob
  qemu_snapshot: revert: remove cleanup label
  qemu_snapshot: revert: move validation to separate function
  qemu_snapshot: revert: move config prepare code to separate function
  qemu_snapshot: revert: emit event right after they are created
  qemu_snapshot: revert: refactor cleanup section
  qemu_snapshot: revert: move saving metadata to separate function
  qemu_snapshot: revert: save metadata within qemu process job
  qemu_snapshot: revert: move active snapshot revert to separate
    function
  qemu_snapshot: revert: rename qemuSnapshotRevertInactive
  qemu_snapshot: revert: move inactive snapshot to separate function

 src/qemu/qemu_snapshot.c | 554 ++++++++++++++++++++++-----------------
 1 file changed, 320 insertions(+), 234 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/14] qemu snapshot revert cleanup and refactor

Posted by Ján Tomko 2 years, 4 months ago

On a Thursday in 2021, Pavel Hrdina wrote:
>Pavel Hrdina (14):
>  qemu_snapshot: revert: fix incorrect jump to cleanup
>  qemu_snapshot: revert: drop unused variable
>  qemu_snapshot: revert: use g_autoptr
>  qemu_snapshot: revert: jump to endjob instead of calling
>    qemuProcessEndJob
>  qemu_snapshot: revert: remove cleanup label
>  qemu_snapshot: revert: move validation to separate function
>  qemu_snapshot: revert: move config prepare code to separate function
>  qemu_snapshot: revert: emit event right after they are created
>  qemu_snapshot: revert: refactor cleanup section
>  qemu_snapshot: revert: move saving metadata to separate function
>  qemu_snapshot: revert: save metadata within qemu process job
>  qemu_snapshot: revert: move active snapshot revert to separate
>    function
>  qemu_snapshot: revert: rename qemuSnapshotRevertInactive
>  qemu_snapshot: revert: move inactive snapshot to separate function
>
> src/qemu/qemu_snapshot.c | 554 ++++++++++++++++++++++-----------------
> 1 file changed, 320 insertions(+), 234 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano