1. Patchew
  2. Libvirt
  3. View series

[PATCH 00/23] virHashFree refactoring and removal

Peter Krempa posted 23 patches 2 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1638282671.git.pkrempa@redhat.com
src/conf/domain_addr.c                 |  2 +-
src/conf/domain_conf.c                 |  6 +--
src/conf/domain_validate.c             | 13 ++---
src/conf/nwfilter_conf.c               |  2 +-
src/conf/nwfilter_ipaddrmap.c          |  3 +-
src/conf/virchrdev.c                   |  2 +-
src/conf/virdomainmomentobjlist.c      |  2 +-
src/conf/virdomainobjlist.c            |  4 +-
src/conf/virinterfaceobj.c             |  2 +-
src/conf/virnetworkobj.c               |  4 +-
src/conf/virnodedeviceobj.c            |  2 +-
src/conf/virnwfilterbindingdef.c       |  2 +-
src/conf/virnwfilterbindingobjlist.c   |  2 +-
src/conf/virsecretobj.c                |  2 +-
src/conf/virstorageobj.c               | 10 ++--
src/hyperv/hyperv_wmi.c                |  2 +-
src/hypervisor/virclosecallbacks.c     |  2 +-
src/libvirt_private.syms               |  1 -
src/libxl/libxl_logger.c               |  9 ++--
src/locking/lock_daemon.c              |  2 +-
src/nwfilter/nwfilter_dhcpsnoop.c      |  6 +--
src/nwfilter/nwfilter_gentech_driver.c | 11 ++--
src/nwfilter/nwfilter_learnipaddr.c    |  7 +--
src/qemu/qemu_checkpoint.c             | 16 +++---
src/qemu/qemu_domain.c                 |  9 ++--
src/qemu/qemu_driver.c                 | 26 ++++------
src/qemu/qemu_migration.c              |  3 +-
src/qemu/qemu_monitor_json.c           |  2 +-
src/qemu/qemu_process.c                | 69 ++++++++------------------
src/rpc/virnetdaemon.c                 |  2 +-
src/security/security_selinux.c        |  6 +--
src/util/virfilecache.c                |  2 +-
src/util/virhash.c                     | 25 ++--------
src/util/virhash.h                     | 13 +----
src/util/virlockspace.c                |  2 +-
src/util/virmacmap.c                   |  2 +-
src/util/virobject.c                   |  4 +-
src/util/virsystemd.c                  |  2 +-
tests/nwfilterxml2firewalltest.c       |  8 ++-
tests/qemumonitorjsontest.c            | 32 ++++++------
tests/qemusecuritymock.c               |  7 ++-
tests/qemuxml2argvtest.c               |  2 +-
42 files changed, 123 insertions(+), 207 deletions(-)
[PATCH 00/23] virHashFree refactoring and removal
Posted by Peter Krempa 2 years, 4 months ago 
Peter Krempa (23):
  virDomainNetDefParseXML: Automatically free GHashTable
  virDomainDeviceValidateAliasImpl: Automatically free GHashTable and
    remove cleanup
  libxlLoggerNew: Avoid virHashFree by rearranging code
  virNWFilterDoInstantiate: Automatically free temporary GHashTable
  virNWFilterBuildAll: Automatically free temporary GHashTable
  qemuDomainUpdateMemoryDeviceInfo: Automatically free temporary
    GHashTable
  qemuDomainBlocksStatsGather: Automatically free GHashTable and
    refactor cleanup
  qemuDomainGetDiskErrors: Automatically free GHashTable
  qemuMigrationSrcFetchMirrorStats: Automatically free GHashTable
  qemuRefreshVirtioChannelState: Automatically free GHashTable and
    refactor cleanup
  qemuRefreshPRManagerState: Automatically free GHashTable and refactor
    cleanup
  qemuProcessWaitForMonitor: Automatically free GHashTable
  qemuProcessRefreshDisks: Automatically free GHashTable and refactor
    cleanup
  qemuProcessRefreshLegacyBlockjobs: Automatically free GHashTable and
    refactor cleanup
  qemuCheckpointGetXMLDescUpdateSize: Don't combine automatic freeing
    with manual
  nwfilterxml2firewalltest: virNWFilterIncludeDefToRuleInst:
    Automatically free GHashTable
  nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically
    free GHashTable
  qemumonitorjsontest: testBlockNodeNameDetect: Automatically free
    GHashTable
  qemumonitorjsontest: mymain: Automatically free GHashTable
  qemuxml2arvtest: Use 'g_hash_table_unref' for clearing the qapi schema
    cache
  Switch away from virHashFree
  util: virhash: Remove 'virHashFree'
  util: virhash: Replace 'virHashDataFree' by 'GDestroyNotify'

 src/conf/domain_addr.c                 |  2 +-
 src/conf/domain_conf.c                 |  6 +--
 src/conf/domain_validate.c             | 13 ++---
 src/conf/nwfilter_conf.c               |  2 +-
 src/conf/nwfilter_ipaddrmap.c          |  3 +-
 src/conf/virchrdev.c                   |  2 +-
 src/conf/virdomainmomentobjlist.c      |  2 +-
 src/conf/virdomainobjlist.c            |  4 +-
 src/conf/virinterfaceobj.c             |  2 +-
 src/conf/virnetworkobj.c               |  4 +-
 src/conf/virnodedeviceobj.c            |  2 +-
 src/conf/virnwfilterbindingdef.c       |  2 +-
 src/conf/virnwfilterbindingobjlist.c   |  2 +-
 src/conf/virsecretobj.c                |  2 +-
 src/conf/virstorageobj.c               | 10 ++--
 src/hyperv/hyperv_wmi.c                |  2 +-
 src/hypervisor/virclosecallbacks.c     |  2 +-
 src/libvirt_private.syms               |  1 -
 src/libxl/libxl_logger.c               |  9 ++--
 src/locking/lock_daemon.c              |  2 +-
 src/nwfilter/nwfilter_dhcpsnoop.c      |  6 +--
 src/nwfilter/nwfilter_gentech_driver.c | 11 ++--
 src/nwfilter/nwfilter_learnipaddr.c    |  7 +--
 src/qemu/qemu_checkpoint.c             | 16 +++---
 src/qemu/qemu_domain.c                 |  9 ++--
 src/qemu/qemu_driver.c                 | 26 ++++------
 src/qemu/qemu_migration.c              |  3 +-
 src/qemu/qemu_monitor_json.c           |  2 +-
 src/qemu/qemu_process.c                | 69 ++++++++------------------
 src/rpc/virnetdaemon.c                 |  2 +-
 src/security/security_selinux.c        |  6 +--
 src/util/virfilecache.c                |  2 +-
 src/util/virhash.c                     | 25 ++--------
 src/util/virhash.h                     | 13 +----
 src/util/virlockspace.c                |  2 +-
 src/util/virmacmap.c                   |  2 +-
 src/util/virobject.c                   |  4 +-
 src/util/virsystemd.c                  |  2 +-
 tests/nwfilterxml2firewalltest.c       |  8 ++-
 tests/qemumonitorjsontest.c            | 32 ++++++------
 tests/qemusecuritymock.c               |  7 ++-
 tests/qemuxml2argvtest.c               |  2 +-
 42 files changed, 123 insertions(+), 207 deletions(-)

-- 
2.31.1
Re: [PATCH 00/23] virHashFree refactoring and removal
Posted by Martin Kletzander 2 years, 4 months ago 
On Tue, Nov 30, 2021 at 03:31:44PM +0100, Peter Krempa wrote:
>Peter Krempa (23):
>  virDomainNetDefParseXML: Automatically free GHashTable
>  virDomainDeviceValidateAliasImpl: Automatically free GHashTable and
>    remove cleanup
>  libxlLoggerNew: Avoid virHashFree by rearranging code
>  virNWFilterDoInstantiate: Automatically free temporary GHashTable
>  virNWFilterBuildAll: Automatically free temporary GHashTable
>  qemuDomainUpdateMemoryDeviceInfo: Automatically free temporary
>    GHashTable
>  qemuDomainBlocksStatsGather: Automatically free GHashTable and
>    refactor cleanup
>  qemuDomainGetDiskErrors: Automatically free GHashTable
>  qemuMigrationSrcFetchMirrorStats: Automatically free GHashTable
>  qemuRefreshVirtioChannelState: Automatically free GHashTable and
>    refactor cleanup
>  qemuRefreshPRManagerState: Automatically free GHashTable and refactor
>    cleanup
>  qemuProcessWaitForMonitor: Automatically free GHashTable
>  qemuProcessRefreshDisks: Automatically free GHashTable and refactor
>    cleanup
>  qemuProcessRefreshLegacyBlockjobs: Automatically free GHashTable and
>    refactor cleanup
>  qemuCheckpointGetXMLDescUpdateSize: Don't combine automatic freeing
>    with manual
>  nwfilterxml2firewalltest: virNWFilterIncludeDefToRuleInst:
>    Automatically free GHashTable
>  nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically
>    free GHashTable
>  qemumonitorjsontest: testBlockNodeNameDetect: Automatically free
>    GHashTable
>  qemumonitorjsontest: mymain: Automatically free GHashTable
>  qemuxml2arvtest: Use 'g_hash_table_unref' for clearing the qapi schema
>    cache
>  Switch away from virHashFree
>  util: virhash: Remove 'virHashFree'
>  util: virhash: Replace 'virHashDataFree' by 'GDestroyNotify'
>

Series

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

Thanks for helping to clean up the codebase ;)

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.