qemu snapshot create cleanup and refactor

[libvirt PATCH 00/11] qemu snapshot create cleanup and refactor

Posted by Pavel Hrdina 2 years, 5 months ago

Pavel Hrdina (11):
  qemu_snapshot: create: move XML parsing to separate function
  qemu_snapshot: create: move XML def validation to separate function
  qemu_snapshot: create: move disk align to separate function
  qemu_snapshot: create: move virDomainSnapshotAssignDef to both code
    paths
  qemu_snapshot: create: virDomainSnapshotGetCurrent is not used with
    redefine
  qemu_snapshot: create: drop update_current variable
  qemu_snapshot: create: refactor endjob in qemuSnapshotCreateXML
  qemu_snapshot: create: move saving metadata to separate function
  qemu_snapshot: create: move snapshot redefine to separate function
  qemu_snapshot: create: move snapshot create to separate function
  qemu_snapshot: create: drop redefine boolean

 src/qemu/qemu_snapshot.c | 409 ++++++++++++++++++++++++---------------
 1 file changed, 251 insertions(+), 158 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/11] qemu snapshot create cleanup and refactor

Posted by Ján Tomko 2 years, 5 months ago

On a Thursday in 2021, Pavel Hrdina wrote:
>Pavel Hrdina (11):
>  qemu_snapshot: create: move XML parsing to separate function
>  qemu_snapshot: create: move XML def validation to separate function
>  qemu_snapshot: create: move disk align to separate function
>  qemu_snapshot: create: move virDomainSnapshotAssignDef to both code
>    paths
>  qemu_snapshot: create: virDomainSnapshotGetCurrent is not used with
>    redefine
>  qemu_snapshot: create: drop update_current variable
>  qemu_snapshot: create: refactor endjob in qemuSnapshotCreateXML
>  qemu_snapshot: create: move saving metadata to separate function
>  qemu_snapshot: create: move snapshot redefine to separate function
>  qemu_snapshot: create: move snapshot create to separate function
>  qemu_snapshot: create: drop redefine boolean
>
> src/qemu/qemu_snapshot.c | 409 ++++++++++++++++++++++++---------------
> 1 file changed, 251 insertions(+), 158 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano