[PATCH 0/2] Fix /proc/*/stat parsing

Martin Kletzander posted 2 patches 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1637340500.git.mkletzan@redhat.com
src/libvirt_linux.syms                |   3 +
src/qemu/qemu_driver.c                |  29 ++----
src/util/virprocess.c                 | 126 +++++++++++++++++---------
src/util/virprocess.h                 |   4 +
tests/meson.build                     |   1 +
tests/virprocessstatdata/complex/stat |   2 +
tests/virprocessstatdata/simple/stat  |   1 +
tests/virprocessstattest.c            |  84 +++++++++++++++++
8 files changed, 185 insertions(+), 65 deletions(-)
create mode 100644 tests/virprocessstatdata/complex/stat
create mode 100644 tests/virprocessstatdata/simple/stat
create mode 100644 tests/virprocessstattest.c

[PATCH 0/2] Fix /proc/*/stat parsing

Posted by Martin Kletzander 2 weeks, 4 days ago
While working on some polkit stuff I found out that we are inconsistent with the
way we parse /proc/*/stat files, so I added a new helper instead along with some
tests.  Unfortunately using it for the thing I wanted is not really viable in
the end, so it "violates" the Rule of three, but at least it does something
correctly.

Martin Kletzander (2):
  util: Add virProcessGetStat
  Use virProcessGetStat

 src/libvirt_linux.syms                |   3 +
 src/qemu/qemu_driver.c                |  29 ++----
 src/util/virprocess.c                 | 126 +++++++++++++++++---------
 src/util/virprocess.h                 |   4 +
 tests/meson.build                     |   1 +
 tests/virprocessstatdata/complex/stat |   2 +
 tests/virprocessstatdata/simple/stat  |   1 +
 tests/virprocessstattest.c            |  84 +++++++++++++++++
 8 files changed, 185 insertions(+), 65 deletions(-)
 create mode 100644 tests/virprocessstatdata/complex/stat
 create mode 100644 tests/virprocessstatdata/simple/stat
 create mode 100644 tests/virprocessstattest.c

-- 
2.34.0

Re: [PATCH 0/2] Fix /proc/*/stat parsing

Posted by Martin Kletzander 2 weeks, 3 days ago
On Fri, Nov 19, 2021 at 06:31:34PM +0100, Martin Kletzander wrote:
>While working on some polkit stuff I found out that we are inconsistent with the
>way we parse /proc/*/stat files, so I added a new helper instead along with some
>tests.  Unfortunately using it for the thing I wanted is not really viable in
>the end, so it "violates" the Rule of three, but at least it does something
>correctly.
>

Self-NACK, v2 coming up.

>Martin Kletzander (2):
>  util: Add virProcessGetStat
>  Use virProcessGetStat
>
> src/libvirt_linux.syms                |   3 +
> src/qemu/qemu_driver.c                |  29 ++----
> src/util/virprocess.c                 | 126 +++++++++++++++++---------
> src/util/virprocess.h                 |   4 +
> tests/meson.build                     |   1 +
> tests/virprocessstatdata/complex/stat |   2 +
> tests/virprocessstatdata/simple/stat  |   1 +
> tests/virprocessstattest.c            |  84 +++++++++++++++++
> 8 files changed, 185 insertions(+), 65 deletions(-)
> create mode 100644 tests/virprocessstatdata/complex/stat
> create mode 100644 tests/virprocessstatdata/simple/stat
> create mode 100644 tests/virprocessstattest.c
>
>-- 
>2.34.0
>