Misc style cleanups

[PATCH 0/4] Misc style cleanups

Michal Privoznik posted 4 patches 2 years, 5 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1636730459.git.mprivozn@redhat.com

examples/c/domain/dommigrate.c       | 11 +++++-----
src/conf/netdev_vport_profile_conf.c | 30 +++++++++-----------------
tools/virsh-nodedev.c                |  5 ++---
tools/virsh-volume.c                 | 32 +++++++++++++---------------
4 files changed, 32 insertions(+), 46 deletions(-)

Expand all Fold all

[PATCH 0/4] Misc style cleanups

Posted by Michal Privoznik 2 years, 5 months ago

This is all done in preparation for dropping needless labels such as:

  cleanup:
     return ret;

I'll post that patch as soon as these are merged.

Michal Prívozník (4):
  virNetDevVPortProfileParse: Use g_autofree
  examples/dommigrate: Don't set retval in usage()
  examples/dommigrate: Make retval portable
  virsh: Remove unnecessary else branches

 examples/c/domain/dommigrate.c       | 11 +++++-----
 src/conf/netdev_vport_profile_conf.c | 30 +++++++++-----------------
 tools/virsh-nodedev.c                |  5 ++---
 tools/virsh-volume.c                 | 32 +++++++++++++---------------
 4 files changed, 32 insertions(+), 46 deletions(-)

-- 
2.32.0

Re: [PATCH 0/4] Misc style cleanups

Posted by Ján Tomko 2 years, 5 months ago

On a Friday in 2021, Michal Privoznik wrote:
>This is all done in preparation for dropping needless labels such as:
>
>  cleanup:
>     return ret;
>
>I'll post that patch as soon as these are merged.
>
>Michal Prívozník (4):
>  virNetDevVPortProfileParse: Use g_autofree
>  examples/dommigrate: Don't set retval in usage()
>  examples/dommigrate: Make retval portable
>  virsh: Remove unnecessary else branches
>
> examples/c/domain/dommigrate.c       | 11 +++++-----
> src/conf/netdev_vport_profile_conf.c | 30 +++++++++-----------------
> tools/virsh-nodedev.c                |  5 ++---
> tools/virsh-volume.c                 | 32 +++++++++++++---------------
> 4 files changed, 32 insertions(+), 46 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [PATCH 0/4] Misc style cleanups

Posted by Kristina Hanicova 2 years, 5 months ago

On Fri, Nov 12, 2021 at 4:26 PM Michal Privoznik <mprivozn@redhat.com>
wrote:

> This is all done in preparation for dropping needless labels such as:
>
>   cleanup:
>      return ret;
>
> I'll post that patch as soon as these are merged.
>
> Michal Prívozník (4):
>   virNetDevVPortProfileParse: Use g_autofree
>   examples/dommigrate: Don't set retval in usage()
>   examples/dommigrate: Make retval portable
>   virsh: Remove unnecessary else branches
>
>  examples/c/domain/dommigrate.c       | 11 +++++-----
>  src/conf/netdev_vport_profile_conf.c | 30 +++++++++-----------------
>  tools/virsh-nodedev.c                |  5 ++---
>  tools/virsh-volume.c                 | 32 +++++++++++++---------------
>  4 files changed, 32 insertions(+), 46 deletions(-)
>
>

Reviewed-by: Kristína Hanicová <khanicov@redhat.com>

Kristína