[PATCH 0/4] qemu: Report stats for backing images

Peter Krempa posted 4 patches 2 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1635777907.git.pkrempa@redhat.com
src/conf/backup_conf.c                        | 10 +--
src/conf/backup_conf.h                        |  3 +-
src/qemu/qemu_backup.c                        |  4 +-
src/qemu/qemu_domain.c                        |  2 +-
src/qemu/qemu_driver.c                        | 61 +++++++++++++++++++
src/qemu/qemu_monitor.c                       |  4 +-
src/qemu/qemu_monitor_json.c                  | 20 +++---
src/qemu/qemu_monitor_json.h                  |  3 +-
tests/genericxml2xmltest.c                    |  2 +-
.../qemustatusxml2xmldata/backup-pull-in.xml  |  9 ++-
10 files changed, 95 insertions(+), 23 deletions(-)
[PATCH 0/4] qemu: Report stats for backing images
Posted by Peter Krempa 2 years, 5 months ago
Management tools such as oVirt need to monitor the 'allocation' of the
backup job scratch file or disk copy target. Add the stats to the bulk
stats.

The stats can be queried by:

 $ virsh domstats $VM --block --backing

Patch 1 fixes a bug in the status XML formatter where we'd not store the
private data for the scratch file of a backup job, which resulted in a
failure of getting the stats after restart of libvirtd.

Peter Krempa (4):
  virDomainBackupDefFormat: Propagate private data callbacks
  qemustatusxml2xmldata: backup-pull: Add private data for scratch image
  qemuMonitorJSONQueryBlockstats: query stats for helper images
  qemuDomainGetStatsBlockExportDisk: Report stats also for helper images

 src/conf/backup_conf.c                        | 10 +--
 src/conf/backup_conf.h                        |  3 +-
 src/qemu/qemu_backup.c                        |  4 +-
 src/qemu/qemu_domain.c                        |  2 +-
 src/qemu/qemu_driver.c                        | 61 +++++++++++++++++++
 src/qemu/qemu_monitor.c                       |  4 +-
 src/qemu/qemu_monitor_json.c                  | 20 +++---
 src/qemu/qemu_monitor_json.h                  |  3 +-
 tests/genericxml2xmltest.c                    |  2 +-
 .../qemustatusxml2xmldata/backup-pull-in.xml  |  9 ++-
 10 files changed, 95 insertions(+), 23 deletions(-)

-- 
2.31.1

Re: [PATCH 0/4] qemu: Report stats for backing images
Posted by Ján Tomko 2 years, 5 months ago
On a Monday in 2021, Peter Krempa wrote:
>Management tools such as oVirt need to monitor the 'allocation' of the
>backup job scratch file or disk copy target. Add the stats to the bulk
>stats.
>
>The stats can be queried by:
>
> $ virsh domstats $VM --block --backing
>
>Patch 1 fixes a bug in the status XML formatter where we'd not store the
>private data for the scratch file of a backup job, which resulted in a
>failure of getting the stats after restart of libvirtd.
>
>Peter Krempa (4):
>  virDomainBackupDefFormat: Propagate private data callbacks
>  qemustatusxml2xmldata: backup-pull: Add private data for scratch image
>  qemuMonitorJSONQueryBlockstats: query stats for helper images
>  qemuDomainGetStatsBlockExportDisk: Report stats also for helper images
>
> src/conf/backup_conf.c                        | 10 +--
> src/conf/backup_conf.h                        |  3 +-
> src/qemu/qemu_backup.c                        |  4 +-
> src/qemu/qemu_domain.c                        |  2 +-
> src/qemu/qemu_driver.c                        | 61 +++++++++++++++++++
> src/qemu/qemu_monitor.c                       |  4 +-
> src/qemu/qemu_monitor_json.c                  | 20 +++---
> src/qemu/qemu_monitor_json.h                  |  3 +-
> tests/genericxml2xmltest.c                    |  2 +-
> .../qemustatusxml2xmldata/backup-pull-in.xml  |  9 ++-
> 10 files changed, 95 insertions(+), 23 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano