qemu_monitor_json: Use g_auto* more

[PATCH 00/13] qemu_monitor_json: Use g_auto* more

Posted by Michal Privoznik 2 years, 5 months ago

*** BLURB HERE ***

Michal Prívozník (13):
  qemu_monitor_json: Don't check for qemuMonitorNextCommandID() retval
  qemu_monitor_json: Don't transfer ownership to @msg
  qemuMonitorJSONHumanCommand: Require @reply_str
  qemuMonitorJSONGetMigrationStats: Don't clear @stats on failure
  qemuMonitorJSONQueryRxFilterParse: Set *filter only on success
  qemu_monitor: Declare and use g_autoptr for qemuMonitorEventPanicInfo
  qemu_monitor_json: Use g_autoptr() for virCPUData
  qemu_monitor_json: Use g_autoptr() for qemuMonitorCPUModelInfo
  qemuMonitorJSONExtractPRManagerInfo: Declare @entry inside the loop
  qemu_monitor_json: Use g_autoptr() for virJSONValue
  qemu_monitor_json: Use g_autofree
  qemu_monitor_json: Drop pointless cleanup labels
  qemu_monitor_json: Drop pointless error labels

 src/qemu/qemu_monitor.c      |    2 +-
 src/qemu/qemu_monitor.h      |    3 +-
 src/qemu/qemu_monitor_json.c | 1803 ++++++++++++----------------------
 3 files changed, 641 insertions(+), 1167 deletions(-)

-- 
2.32.0

Re: [PATCH 00/13] qemu_monitor_json: Use g_auto* more

Posted by Tim Wiederhake 2 years, 5 months ago

On Mon, 2021-10-25 at 12:57 +0200, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (13):
>   qemu_monitor_json: Don't check for qemuMonitorNextCommandID()
> retval
>   qemu_monitor_json: Don't transfer ownership to @msg
>   qemuMonitorJSONHumanCommand: Require @reply_str
>   qemuMonitorJSONGetMigrationStats: Don't clear @stats on failure
>   qemuMonitorJSONQueryRxFilterParse: Set *filter only on success
>   qemu_monitor: Declare and use g_autoptr for
> qemuMonitorEventPanicInfo
>   qemu_monitor_json: Use g_autoptr() for virCPUData
>   qemu_monitor_json: Use g_autoptr() for qemuMonitorCPUModelInfo
>   qemuMonitorJSONExtractPRManagerInfo: Declare @entry inside the loop
>   qemu_monitor_json: Use g_autoptr() for virJSONValue
>   qemu_monitor_json: Use g_autofree
>   qemu_monitor_json: Drop pointless cleanup labels
>   qemu_monitor_json: Drop pointless error labels
> 
>  src/qemu/qemu_monitor.c      |    2 +-
>  src/qemu/qemu_monitor.h      |    3 +-
>  src/qemu/qemu_monitor_json.c | 1803 ++++++++++++--------------------
> --
>  3 files changed, 641 insertions(+), 1167 deletions(-)
> 

> 1167 deletions
Thanks!

Reviewed-by: Tim Wiederhake <twiederh@redhat.com>

Tim