[PATCH 00/14] qemu: Type-aware generation of properties for -device (part 2)

Peter Krempa posted 14 patches 1 week, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1634037045.git.pkrempa@redhat.com
src/conf/domain_conf.c          |  23 +-
src/conf/domain_conf.h          |   2 +-
src/qemu/qemu_command.c         | 366 +++++++++++++++++---------------
src/qemu/qemu_validate.c        |  35 +--
src/security/security_selinux.c |  10 +-
5 files changed, 232 insertions(+), 204 deletions(-)

[PATCH 00/14] qemu: Type-aware generation of properties for -device (part 2)

Posted by Peter Krempa 1 week, 3 days ago
This series finishes the refactor to generate '-device' via JSON. This
will be needed later on when qemu will consider only the JSON format to
be long term stable.

Next part will deal with the testing and finishing touches.

Peter Krempa (14):
  qemuBuildStorageSourceAttachPrepareDrive: Fix function comment
  qemuBuildDeviceCommandlineFromJSON: Remove unused keyword
  qemuValidateDomainSmartcardDef: Unbreak error messages
  qemuValidateDomainSmartcardDef: Move chardev validation under
    VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH
  virDomainSmartcardDef: Declare 'type' as virDomainSmartcardType
  qemuBuildSmartcardCommandLine: Replace
    qemuBuildSmartcardFindCCIDController
  qemuValidateDomainSmartcardDef: Move validation of smartcard count
  qemuBuildVMGenIDCommandLine: Generate via JSON
  qemuBuildTPMProxyCommandLine: Generate via JSON
  qemuBuildVMCoreInfoCommandLine: Generate via JSON
  qemuBuildIOMMUCommandLine: Generate via JSON
  qemuBuildSmartcardCommandLine: Generate via JSON
  qemuBuildFloppyCommandLineControllerOptions: Extract formatting of
    implicit/explicit fdc
  qemuBuildFloppyCommandLineControllerOptionsExplicit: Generate via JSON

 src/conf/domain_conf.c          |  23 +-
 src/conf/domain_conf.h          |   2 +-
 src/qemu/qemu_command.c         | 366 +++++++++++++++++---------------
 src/qemu/qemu_validate.c        |  35 +--
 src/security/security_selinux.c |  10 +-
 5 files changed, 232 insertions(+), 204 deletions(-)

-- 
2.31.1

Re: [PATCH 00/14] qemu: Type-aware generation of properties for -device (part 2)

Posted by Ján Tomko 1 week, 2 days ago
On a Tuesday in 2021, Peter Krempa wrote:
>This series finishes the refactor to generate '-device' via JSON. This
>will be needed later on when qemu will consider only the JSON format to
>be long term stable.
>
>Next part will deal with the testing and finishing touches.
>
>Peter Krempa (14):
>  qemuBuildStorageSourceAttachPrepareDrive: Fix function comment
>  qemuBuildDeviceCommandlineFromJSON: Remove unused keyword
>  qemuValidateDomainSmartcardDef: Unbreak error messages
>  qemuValidateDomainSmartcardDef: Move chardev validation under
>    VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH
>  virDomainSmartcardDef: Declare 'type' as virDomainSmartcardType
>  qemuBuildSmartcardCommandLine: Replace
>    qemuBuildSmartcardFindCCIDController
>  qemuValidateDomainSmartcardDef: Move validation of smartcard count
>  qemuBuildVMGenIDCommandLine: Generate via JSON
>  qemuBuildTPMProxyCommandLine: Generate via JSON
>  qemuBuildVMCoreInfoCommandLine: Generate via JSON
>  qemuBuildIOMMUCommandLine: Generate via JSON
>  qemuBuildSmartcardCommandLine: Generate via JSON
>  qemuBuildFloppyCommandLineControllerOptions: Extract formatting of
>    implicit/explicit fdc
>  qemuBuildFloppyCommandLineControllerOptionsExplicit: Generate via JSON
>
> src/conf/domain_conf.c          |  23 +-
> src/conf/domain_conf.h          |   2 +-
> src/qemu/qemu_command.c         | 366 +++++++++++++++++---------------
> src/qemu/qemu_validate.c        |  35 +--
> src/security/security_selinux.c |  10 +-
> 5 files changed, 232 insertions(+), 204 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano