[PATCH 075/103] qemuBuildIoEventFdStr: Always assume support for QEMU_CAPS_VIRTIO_IOEVENTFD

Peter Krempa posted 103 patches 4 years, 4 months ago
Only 102 patches received!
[PATCH 075/103] qemuBuildIoEventFdStr: Always assume support for QEMU_CAPS_VIRTIO_IOEVENTFD
Posted by Peter Krempa 4 years, 4 months ago
The support for the 'ioeventfd' knob of virtio devices was introduced by
QEMU commit 25db9ebe15125 contained in v0.14.0-rc0 and it can't be
compiled out. Thus libvirt can assume it's support and remove
conditional code.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_command.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 008700cc5f..0ff933fde9 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1339,9 +1339,9 @@ qemuBuildRomStr(virBuffer *buf,
 static int
 qemuBuildIoEventFdStr(virBuffer *buf,
                       virTristateSwitch use,
-                      virQEMUCaps *qemuCaps)
+                      virQEMUCaps *qemuCaps G_GNUC_UNUSED)
 {
-    if (use && virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_IOEVENTFD))
+    if (use)
         virBufferAsprintf(buf, ",ioeventfd=%s",
                           virTristateSwitchTypeToString(use));
     return 0;
-- 
2.31.1

Re: [PATCH 075/103] qemuBuildIoEventFdStr: Always assume support for QEMU_CAPS_VIRTIO_IOEVENTFD
Posted by Ján Tomko 4 years, 4 months ago
On a Thursday in 2021, Peter Krempa wrote:
>The support for the 'ioeventfd' knob of virtio devices was introduced by
>QEMU commit 25db9ebe15125 contained in v0.14.0-rc0 and it can't be
>compiled out. Thus libvirt can assume it's support and remove

its support
it's supported

>conditional code.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano