qemu: Type-aware generation of properties for -device (part 1)

[PATCH 018/103] qemu: capabilities: Introduce QEMU_CAPS_DEVICE_JSON

Posted by Peter Krempa 4 years, 4 months ago

The flag will be used to switch use of JSON arguments for -device once
qemu will support it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_capabilities.c | 3 +++
 src/qemu/qemu_capabilities.h | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 02fdeea595..4bed967782 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -646,6 +646,9 @@ VIR_ENUM_IMPL(virQEMUCaps,
               "piix4.acpi-root-pci-hotplug", /* QEMU_CAPS_PIIX4_ACPI_ROOT_PCI_HOTPLUG */
               "netdev.json", /* QEMU_CAPS_NETDEV_JSON */
               "chardev.json", /* QEMU_CAPS_CHARDEV_JSON */
+
+              /* 415 */
+              "device.json", /* QEMU_CAPS_DEVICE_JSON */
     );


diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 37ce0a1d54..16a36da63d 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -627,6 +627,9 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     QEMU_CAPS_NETDEV_JSON, /* -netdev accepts JSON */
     QEMU_CAPS_CHARDEV_JSON, /* -chardev accepts JSON */

+    /* 415 */
+    QEMU_CAPS_DEVICE_JSON, /* -device accepts JSON */
+
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;

-- 
2.31.1

Re: [PATCH 018/103] qemu: capabilities: Introduce QEMU_CAPS_DEVICE_JSON

Posted by Ján Tomko 4 years, 4 months ago

On a Thursday in 2021, Peter Krempa wrote:
>The flag will be used to switch use of JSON arguments for -device once
>qemu will support it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_capabilities.c | 3 +++
> src/qemu/qemu_capabilities.h | 3 +++
> 2 files changed, 6 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano