[libvirt PATCHv2 3/5] qemu: Revert "qemuExtDevicesStart: pass logManager"

Ján Tomko posted 5 patches 4 years, 4 months ago
[libvirt PATCHv2 3/5] qemu: Revert "qemuExtDevicesStart: pass logManager"
Posted by Ján Tomko 4 years, 4 months ago
This reverts commit b164eac5e1d4ebe17e673f0427b70f862a670f94

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_extdevice.c | 1 -
 src/qemu/qemu_extdevice.h | 1 -
 src/qemu/qemu_process.c   | 4 +---
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index 3c34bb8321..537b130394 100644
--- a/src/qemu/qemu_extdevice.c
+++ b/src/qemu/qemu_extdevice.c
@@ -166,7 +166,6 @@ qemuExtDevicesCleanupHost(virQEMUDriver *driver,
 int
 qemuExtDevicesStart(virQEMUDriver *driver,
                     virDomainObj *vm,
-                    virLogManager *logManager G_GNUC_UNUSED,
                     bool incomingMigration)
 {
     virDomainDef *def = vm->def;
diff --git a/src/qemu/qemu_extdevice.h b/src/qemu/qemu_extdevice.h
index 5f638438a8..43d2a4dfff 100644
--- a/src/qemu/qemu_extdevice.h
+++ b/src/qemu/qemu_extdevice.h
@@ -46,7 +46,6 @@ void qemuExtDevicesCleanupHost(virQEMUDriver *driver,
 
 int qemuExtDevicesStart(virQEMUDriver *driver,
                         virDomainObj *vm,
-                        virLogManager *logManager,
                         bool incomingMigration)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2)
     G_GNUC_WARN_UNUSED_RESULT;
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 1d0165af6d..96b7d1edc7 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7238,9 +7238,7 @@ qemuProcessLaunch(virConnectPtr conn,
     if (qemuProcessGenID(vm, flags) < 0)
         goto cleanup;
 
-    if (qemuExtDevicesStart(driver, vm,
-                            qemuDomainLogContextGetManager(logCtxt),
-                            incoming != NULL) < 0)
+    if (qemuExtDevicesStart(driver, vm, incoming != NULL) < 0)
         goto cleanup;
 
     VIR_DEBUG("Building emulator command line");
-- 
2.31.1

Re: [libvirt PATCHv2 3/5] qemu: Revert "qemuExtDevicesStart: pass logManager"
Posted by Peter Krempa 4 years, 4 months ago
On Wed, Oct 06, 2021 at 12:20:21 +0200, Ján Tomko wrote:
> This reverts commit b164eac5e1d4ebe17e673f0427b70f862a670f94
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_extdevice.c | 1 -
>  src/qemu/qemu_extdevice.h | 1 -
>  src/qemu/qemu_process.c   | 4 +---
>  3 files changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>