[v1] qemu: implement virtiofs hot(un)plug (virtiofs epopee)

[libvirt PATCH 11/16] qemu: vhost-user-fs: build extdevice for zpci

Posted by Ján Tomko 4 years, 4 months ago

Other devices (includes 9p-based fsdev) call this wrapper
before formatting the device.

Add it here too.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_command.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index dc4f91ce25..8c8aafb13d 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2095,6 +2095,9 @@ qemuBuildVHostUserFsCommandLine(virCommand *cmd,
     virCommandAddArg(cmd, "-chardev");
     virCommandAddArg(cmd, chrdevstr);
 
+    if (qemuCommandAddExtDevice(cmd, &fs->info) < 0)
+        return -1;
+
     if (!(devstr = qemuBuildVHostUserFsDevStr(fs, def, chardev_alias, priv)))
         return -1;
 
-- 
2.31.1

Re: [libvirt PATCH 11/16] qemu: vhost-user-fs: build extdevice for zpci

Posted by Peter Krempa 4 years, 4 months ago

On Wed, Oct 06, 2021 at 09:15:17 +0200, Ján Tomko wrote:
> Other devices (includes 9p-based fsdev) call this wrapper
> before formatting the device.
> 
> Add it here too.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_command.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>