[libvirt PATCH 00/24] tests: use g_auto more (glib chronicles)

Ján Tomko posted 24 patches 2 weeks, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1630788206.git.jtomko@redhat.com
src/conf/network_conf.h               |   1 +
src/util/virmacmap.h                  |   2 +
tests/cputest.c                       |  51 ++++-------
tests/domaincapstest.c                |  60 +++++--------
tests/domainconftest.c                |  18 ++--
tests/eventtest.c                     |   3 +-
tests/fchosttest.c                    |  70 +++++----------
tests/fdstreamtest.c                  |  24 ++---
tests/genericxml2xmltest.c            |   6 +-
tests/interfacexml2xmltest.c          |   9 +-
tests/libxlxml2domconfigtest.c        |  18 ++--
tests/lxcconf2xmltest.c               |  37 +++-----
tests/lxcxml2xmltest.c                |   6 +-
tests/metadatatest.c                  |  37 +++-----
tests/networkxml2conftest.c           |  19 ++--
tests/networkxml2firewalltest.c       |   9 +-
tests/networkxml2xmltest.c            |  13 +--
tests/networkxml2xmlupdatetest.c      |  16 ++--
tests/nodedevxml2xmltest.c            |   9 +-
tests/nsstest.c                       |   4 +-
tests/nwfilterebiptablestest.c        |  84 ++++++-----------
tests/nwfilterxml2firewalltest.c      |  12 +--
tests/nwfilterxml2xmltest.c           |  10 +--
tests/openvzutilstest.c               |  23 ++---
tests/qemuagenttest.c                 |  31 ++-----
tests/qemucapsprobemock.c             |  12 +--
tests/qemucommandutiltest.c           |  15 ++--
tests/qemumonitorjsontest.c           | 116 +++++++++---------------
tests/qemumonitortestutils.c          |  45 +++-------
tests/qemuxml2argvtest.c              |  24 ++---
tests/scsihosttest.c                  |  37 +++-----
tests/secretxml2xmltest.c             |   7 +-
tests/securityselinuxlabeltest.c      |  27 ++----
tests/sockettest.c                    |   4 +-
tests/testutils.c                     |   8 +-
tests/testutilslxc.c                  |   4 +-
tests/vboxsnapshotxmltest.c           |  12 +--
tests/vircapstest.c                   |  20 ++---
tests/vircgrouptest.c                 |   3 +-
tests/virconftest.c                   |  44 ++++-----
tests/vircryptotest.c                 |  35 +++-----
tests/virfilecachetest.c              |   3 +-
tests/virfilemock.c                   |   3 +-
tests/virfiletest.c                   |  61 +++++--------
tests/virhostcputest.c                |  42 +++------
tests/viriscsitest.c                  |  18 ++--
tests/virkmodtest.c                   |  39 +++-----
tests/virmacmaptest.c                 |  49 ++++------
tests/virnetdaemontest.c              |  13 ++-
tests/virnetsockettest.c              |   6 +-
tests/virnettlshelpers.c              |   4 +-
tests/virnetworkportxml2xmltest.c     |  23 ++---
tests/virnumamock.c                   |  14 +--
tests/virnwfilterbindingxml2xmltest.c |   7 +-
tests/virpcimock.c                    |   4 +-
tests/virpcitest.c                    |  56 +++++-------
tests/virresctrltest.c                |  34 +++----
tests/virrotatingfiletest.c           |   4 +-
tests/virscsitest.c                   |  31 ++-----
tests/virstringtest.c                 |  44 +++------
tests/virsystemdtest.c                |  29 ++----
tests/virtestmock.c                   |  10 +--
tests/viruritest.c                    |   3 +-
tests/virusbmock.c                    |   7 +-
tests/virusbtest.c                    |   6 +-
tests/vmwarevertest.c                 |  20 ++---
tests/vmx2xmltest.c                   |  35 +++-----
tests/vshtabletest.c                  | 125 ++++++++++----------------
tests/xlconfigtest.c                  |  85 +++++++-----------
tests/xmconfigtest.c                  |  62 +++++--------
tests/xml2vmxtest.c                   |  32 +++----
71 files changed, 628 insertions(+), 1226 deletions(-)

[libvirt PATCH 00/24] tests: use g_auto more (glib chronicles)

Posted by Ján Tomko 2 weeks, 6 days ago
Ján Tomko (24):
  tests: virnetdaemontest: split variable declarations
  conf: add cleanup func for virNetworkXMLOption
  conf: add cleanup func for virMacMap
  tests: use g_autoptr instead of virObjectUnref
  tests: qemu: use g_autofree
  tests: network: use g_autofree
  tests: libxl: use g_autofree
  tests: nwfilter: use g_autofree
  tests: vmx: use g_autofree
  tests: vir: use g_autofree
  tests: use g_autofree
  tests: use g_autoptr instead of virJSONValueFree
  tests: use g_auto for virCPUDataFree
  tests: use g_auto instead of VIR_FORCE_FCLOSE
  tests: use VIR_AUTOCLOSE
  tests: use g_auto instead of vshTableFree
  tests: use g_auto instead of virDomainFree
  tests: qemu: remove pointless labels
  tests: vmx: remove pointless labels
  tests: libxl: remove pointless labels
  tests: nwfilter: remove pointless labels
  tests: vshtabletest: remove pointless labels
  tests: vir: remove pointless labels
  tests: remove pointless labels

 src/conf/network_conf.h               |   1 +
 src/util/virmacmap.h                  |   2 +
 tests/cputest.c                       |  51 ++++-------
 tests/domaincapstest.c                |  60 +++++--------
 tests/domainconftest.c                |  18 ++--
 tests/eventtest.c                     |   3 +-
 tests/fchosttest.c                    |  70 +++++----------
 tests/fdstreamtest.c                  |  24 ++---
 tests/genericxml2xmltest.c            |   6 +-
 tests/interfacexml2xmltest.c          |   9 +-
 tests/libxlxml2domconfigtest.c        |  18 ++--
 tests/lxcconf2xmltest.c               |  37 +++-----
 tests/lxcxml2xmltest.c                |   6 +-
 tests/metadatatest.c                  |  37 +++-----
 tests/networkxml2conftest.c           |  19 ++--
 tests/networkxml2firewalltest.c       |   9 +-
 tests/networkxml2xmltest.c            |  13 +--
 tests/networkxml2xmlupdatetest.c      |  16 ++--
 tests/nodedevxml2xmltest.c            |   9 +-
 tests/nsstest.c                       |   4 +-
 tests/nwfilterebiptablestest.c        |  84 ++++++-----------
 tests/nwfilterxml2firewalltest.c      |  12 +--
 tests/nwfilterxml2xmltest.c           |  10 +--
 tests/openvzutilstest.c               |  23 ++---
 tests/qemuagenttest.c                 |  31 ++-----
 tests/qemucapsprobemock.c             |  12 +--
 tests/qemucommandutiltest.c           |  15 ++--
 tests/qemumonitorjsontest.c           | 116 +++++++++---------------
 tests/qemumonitortestutils.c          |  45 +++-------
 tests/qemuxml2argvtest.c              |  24 ++---
 tests/scsihosttest.c                  |  37 +++-----
 tests/secretxml2xmltest.c             |   7 +-
 tests/securityselinuxlabeltest.c      |  27 ++----
 tests/sockettest.c                    |   4 +-
 tests/testutils.c                     |   8 +-
 tests/testutilslxc.c                  |   4 +-
 tests/vboxsnapshotxmltest.c           |  12 +--
 tests/vircapstest.c                   |  20 ++---
 tests/vircgrouptest.c                 |   3 +-
 tests/virconftest.c                   |  44 ++++-----
 tests/vircryptotest.c                 |  35 +++-----
 tests/virfilecachetest.c              |   3 +-
 tests/virfilemock.c                   |   3 +-
 tests/virfiletest.c                   |  61 +++++--------
 tests/virhostcputest.c                |  42 +++------
 tests/viriscsitest.c                  |  18 ++--
 tests/virkmodtest.c                   |  39 +++-----
 tests/virmacmaptest.c                 |  49 ++++------
 tests/virnetdaemontest.c              |  13 ++-
 tests/virnetsockettest.c              |   6 +-
 tests/virnettlshelpers.c              |   4 +-
 tests/virnetworkportxml2xmltest.c     |  23 ++---
 tests/virnumamock.c                   |  14 +--
 tests/virnwfilterbindingxml2xmltest.c |   7 +-
 tests/virpcimock.c                    |   4 +-
 tests/virpcitest.c                    |  56 +++++-------
 tests/virresctrltest.c                |  34 +++----
 tests/virrotatingfiletest.c           |   4 +-
 tests/virscsitest.c                   |  31 ++-----
 tests/virstringtest.c                 |  44 +++------
 tests/virsystemdtest.c                |  29 ++----
 tests/virtestmock.c                   |  10 +--
 tests/viruritest.c                    |   3 +-
 tests/virusbmock.c                    |   7 +-
 tests/virusbtest.c                    |   6 +-
 tests/vmwarevertest.c                 |  20 ++---
 tests/vmx2xmltest.c                   |  35 +++-----
 tests/vshtabletest.c                  | 125 ++++++++++----------------
 tests/xlconfigtest.c                  |  85 +++++++-----------
 tests/xmconfigtest.c                  |  62 +++++--------
 tests/xml2vmxtest.c                   |  32 +++----
 71 files changed, 628 insertions(+), 1226 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/24] tests: use g_auto more (glib chronicles)

Posted by Laine Stump 2 weeks, 4 days ago
On 9/4/21 4:43 PM, Ján Tomko wrote:
> Ján Tomko (24):
>    tests: virnetdaemontest: split variable declarations
>    conf: add cleanup func for virNetworkXMLOption
>    conf: add cleanup func for virMacMap
>    tests: use g_autoptr instead of virObjectUnref
>    tests: qemu: use g_autofree
>    tests: network: use g_autofree
>    tests: libxl: use g_autofree
>    tests: nwfilter: use g_autofree
>    tests: vmx: use g_autofree
>    tests: vir: use g_autofree
>    tests: use g_autofree
>    tests: use g_autoptr instead of virJSONValueFree
>    tests: use g_auto for virCPUDataFree
>    tests: use g_auto instead of VIR_FORCE_FCLOSE
>    tests: use VIR_AUTOCLOSE
>    tests: use g_auto instead of vshTableFree
>    tests: use g_auto instead of virDomainFree
>    tests: qemu: remove pointless labels
>    tests: vmx: remove pointless labels
>    tests: libxl: remove pointless labels
>    tests: nwfilter: remove pointless labels
>    tests: vshtabletest: remove pointless labels
>    tests: vir: remove pointless labels

You missed removal of one cleanup: label in 23/24 (I had assumed it 
would give a compile warning in that case, but the CI pipeline passed 
it, so...)

>    tests: remove pointless labels

>   71 files changed, 628 insertions(+), 1226 deletions(-)

Beer-worthy statistics!

I had a couple random comments beyond the one up above, but that's the 
only one that needs any action. Once you've fixed that, series:

Reviewed-by: Laine Stump <laine@redhat.com>