[v1] network create: add support for validation against schema

[PATCH 3/6] api: add virNetworkCreateFlags

Posted by Kristina Hanicova 4 years, 5 months ago

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
---
 include/libvirt/libvirt-network.h | 4 ++++
 src/libvirt-network.c             | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-network.h
index 0be4d64b75..d8eaf83d93 100644
--- a/include/libvirt/libvirt-network.h
+++ b/include/libvirt/libvirt-network.h
@@ -113,6 +113,10 @@ virNetworkPtr           virNetworkLookupByUUID          (virConnectPtr conn,
 virNetworkPtr           virNetworkLookupByUUIDString    (virConnectPtr conn,
                                                          const char *uuid);
 
+typedef enum {
+    VIR_NETWORK_CREATE_VALIDATE = 1 << 0, /* Validate the XML document against schema */
+} virNetworkCreateFlags;
+
 /*
  * Create active transient network
  */
diff --git a/src/libvirt-network.c b/src/libvirt-network.c
index 32ade1a2aa..33bb547a3c 100644
--- a/src/libvirt-network.c
+++ b/src/libvirt-network.c
@@ -431,7 +431,7 @@ virNetworkCreateXML(virConnectPtr conn, const char *xmlDesc)
  * virNetworkCreateXMLFlags:
  * @conn: pointer to the hypervisor connection
  * @xmlDesc: an XML description of the network
- * @flags: extra flags; not used yet, so callers should always pass 0
+ * @flags: bitwise-OR of virNetworkCreateFlags
  *
  * Create and start a new virtual network, based on an XML description
  * similar to the one returned by virNetworkGetXMLDesc()
-- 
2.31.1

Re: [PATCH 3/6] api: add virNetworkCreateFlags

Posted by Ján Tomko 4 years, 5 months ago

On a Thursday in 2021, Kristina Hanicova wrote:
>Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
>---
> include/libvirt/libvirt-network.h | 4 ++++
> src/libvirt-network.c             | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-network.h
>index 0be4d64b75..d8eaf83d93 100644
>--- a/include/libvirt/libvirt-network.h
>+++ b/include/libvirt/libvirt-network.h
>@@ -113,6 +113,10 @@ virNetworkPtr           virNetworkLookupByUUID          (virConnectPtr conn,
> virNetworkPtr           virNetworkLookupByUUIDString    (virConnectPtr conn,
>                                                          const char *uuid);
>
>+typedef enum {
>+    VIR_NETWORK_CREATE_VALIDATE = 1 << 0, /* Validate the XML document against schema */

I'd write this as:
   VIR_NETWORK_CREATE_VALIDATE = VIR_NETWORK_DEFINE_VALIDATE,
to make it obvious we use them interchangeably.

Jano

>+} virNetworkCreateFlags;
>+
> /*
>  * Create active transient network
>  */