[PATCH 0/4] storage pool define: add support for validation against schema

Kristina Hanicova posted 4 patches 2 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1629815312.git.khanicov@redhat.com
docs/manpages/virsh.rst           |  4 +++-
include/libvirt/libvirt-storage.h |  4 ++++
src/conf/domain_conf.c            |  2 +-
src/conf/storage_conf.c           | 13 ++++++++-----
src/conf/storage_conf.h           |  3 ++-
src/libvirt-storage.c             |  2 +-
src/storage/storage_driver.c      |  6 +++---
src/test/test_driver.c            |  6 +++---
tools/virsh-pool.c                | 11 +++++++++--
9 files changed, 34 insertions(+), 17 deletions(-)
[PATCH 0/4] storage pool define: add support for validation against schema
Posted by Kristina Hanicova 2 years, 7 months ago
Kristina Hanicova (4):
  api: add virStoragePoolDefineFlags
  storage_conf: add validation against schema in pool define
  storage_driver & test_driver: allow VIR_STORAGE_POOL_DEFINE_VALIDATE
    flag
  virsh: add support for '--validate' option in define storage pool

 docs/manpages/virsh.rst           |  4 +++-
 include/libvirt/libvirt-storage.h |  4 ++++
 src/conf/domain_conf.c            |  2 +-
 src/conf/storage_conf.c           | 13 ++++++++-----
 src/conf/storage_conf.h           |  3 ++-
 src/libvirt-storage.c             |  2 +-
 src/storage/storage_driver.c      |  6 +++---
 src/test/test_driver.c            |  6 +++---
 tools/virsh-pool.c                | 11 +++++++++--
 9 files changed, 34 insertions(+), 17 deletions(-)

-- 
2.31.1

Re: [PATCH 0/4] storage pool define: add support for validation against schema
Posted by Michal Prívozník 2 years, 7 months ago
On 8/24/21 4:51 PM, Kristina Hanicova wrote:
> 
> Kristina Hanicova (4):
>   api: add virStoragePoolDefineFlags
>   storage_conf: add validation against schema in pool define
>   storage_driver & test_driver: allow VIR_STORAGE_POOL_DEFINE_VALIDATE
>     flag
>   virsh: add support for '--validate' option in define storage pool
> 
>  docs/manpages/virsh.rst           |  4 +++-
>  include/libvirt/libvirt-storage.h |  4 ++++
>  src/conf/domain_conf.c            |  2 +-
>  src/conf/storage_conf.c           | 13 ++++++++-----
>  src/conf/storage_conf.h           |  3 ++-
>  src/libvirt-storage.c             |  2 +-
>  src/storage/storage_driver.c      |  6 +++---
>  src/test/test_driver.c            |  6 +++---
>  tools/virsh-pool.c                | 11 +++++++++--
>  9 files changed, 34 insertions(+), 17 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal