qemu: capabilities: use g_auto (glib chronicles)

[libvirt PATCH 0/6] qemu: capabilities: use g_auto (glib chronicles)

Posted by Ján Tomko 2 years, 8 months ago

This is not a cover letter.

Ján Tomko (6):
  qemu: refactor virQEMUCapsNewForBinaryInternal
  qemu: refactor virQEMUCapsLoadFile
  qemu: refactor virQEMUCapsInit
  qemu: refactor virQEMUCapsNewCopy
  qemu: capabilities: use g_auto
  qemu: capabilities: remove pointless labels

 src/qemu/qemu_capabilities.c | 134 ++++++++++++-----------------------
 1 file changed, 45 insertions(+), 89 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/6] qemu: capabilities: use g_auto (glib chronicles)

Posted by Kristina Hanicova 2 years, 8 months ago

On Mon, Aug 23, 2021 at 4:38 PM Ján Tomko <jtomko@redhat.com> wrote:

> This is not a cover letter.
>
> Ján Tomko (6):
>   qemu: refactor virQEMUCapsNewForBinaryInternal
>   qemu: refactor virQEMUCapsLoadFile
>   qemu: refactor virQEMUCapsInit
>   qemu: refactor virQEMUCapsNewCopy
>   qemu: capabilities: use g_auto
>   qemu: capabilities: remove pointless labels
>
>  src/qemu/qemu_capabilities.c | 134 ++++++++++++-----------------------
>  1 file changed, 45 insertions(+), 89 deletions(-)
>
> --
> 2.31.1



Reviewed-by:  Kristina Hanicova <khanicov@redhat.com>

Kristina

Re: [libvirt PATCH 0/6] qemu: capabilities: use g_auto (glib chronicles)

Posted by Martin Kletzander 2 years, 7 months ago

On Mon, Aug 23, 2021 at 05:26:43PM +0200, Kristina Hanicova wrote:
>On Mon, Aug 23, 2021 at 4:38 PM Ján Tomko <jtomko@redhat.com> wrote:
>
>> This is not a cover letter.
>>
>> Ján Tomko (6):
>>   qemu: refactor virQEMUCapsNewForBinaryInternal
>>   qemu: refactor virQEMUCapsLoadFile
>>   qemu: refactor virQEMUCapsInit
>>   qemu: refactor virQEMUCapsNewCopy
>>   qemu: capabilities: use g_auto
>>   qemu: capabilities: remove pointless labels
>>
>>  src/qemu/qemu_capabilities.c | 134 ++++++++++++-----------------------
>>  1 file changed, 45 insertions(+), 89 deletions(-)
>>
>> --
>> 2.31.1
>
>
>
>Reviewed-by:  Kristina Hanicova <khanicov@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

Re: [libvirt PATCH 0/6] qemu: capabilities: use g_auto (glib chronicles)

Posted by Michal Prívozník 2 years, 7 months ago

On 8/24/21 3:22 PM, Martin Kletzander wrote:
> On Mon, Aug 23, 2021 at 05:26:43PM +0200, Kristina Hanicova wrote:
>> On Mon, Aug 23, 2021 at 4:38 PM Ján Tomko <jtomko@redhat.com> wrote:
>>
>>> This is not a cover letter.
>>>
>>> Ján Tomko (6):
>>>   qemu: refactor virQEMUCapsNewForBinaryInternal
>>>   qemu: refactor virQEMUCapsLoadFile
>>>   qemu: refactor virQEMUCapsInit
>>>   qemu: refactor virQEMUCapsNewCopy
>>>   qemu: capabilities: use g_auto
>>>   qemu: capabilities: remove pointless labels
>>>
>>>  src/qemu/qemu_capabilities.c | 134 ++++++++++++-----------------------
>>>  1 file changed, 45 insertions(+), 89 deletions(-)
>>>
>>> -- 
>>> 2.31.1
>>
>>
>>
>> Reviewed-by:  Kristina Hanicova <khanicov@redhat.com>
> 
> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal