[libvirt PATCH 00/12] tools: virsh: use g_auto more (glib chronicles)

Ján Tomko posted 12 patches 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1628756993.git.jtomko@redhat.com
src/util/virxml.h                  |    1 +
tools/virsh-completer-checkpoint.c |    4 +-
tools/virsh-completer-domain.c     |   57 +-
tools/virsh-completer-snapshot.c   |    3 +-
tools/virsh-domain-monitor.c       |  256 ++----
tools/virsh-domain.c               | 1225 ++++++++++------------------
tools/virsh-host.c                 |  212 ++---
tools/virsh-interface.c            |   21 +-
tools/virsh-network.c              |   24 +-
tools/virsh-nodedev.c              |   27 +-
tools/virsh-nwfilter.c             |   15 +-
tools/virsh-pool.c                 |   34 +-
tools/virsh-secret.c               |    9 +-
tools/virsh-util.c                 |    3 +-
tools/virsh-volume.c               |   35 +-
tools/virsh.c                      |    3 +-
tools/virt-admin.c                 |    6 +-
tools/vsh.c                        |   11 +-
18 files changed, 660 insertions(+), 1286 deletions(-)
[libvirt PATCH 00/12] tools: virsh: use g_auto more (glib chronicles)
Posted by Ján Tomko 2 years, 8 months ago
Incomprehensive series removing many cleanup sections.

Patch 1/12 is common with my other series:
[libvirt PATCH 0/3] xml: use g_auto for xmlXPathObject

Ján Tomko (12):
  util: define cleanup func for xmlXPathObject
  tools: virsh: split variable declarations
  tools: virsh: cmdDominfo: rename 'ostype' variable
  tools: virsh: use automatic cleanup for virDomainObj
  tools: virsh: use automatic cleanup for xmlXPathContext
  tools: virsh: use automatic cleanup for xmlXPathObject
  tools: virsh: use automatic cleanup for xmlDoc
  tools: virsh: use automatic cleanup for vshTable
  tools: virsh: reduce variable scope to use automatic cleanup
  tools: virsh: use automatic cleanup for char **
  tools: virsh: use g_autofree
  tools: virsh: remove redundant labels

 src/util/virxml.h                  |    1 +
 tools/virsh-completer-checkpoint.c |    4 +-
 tools/virsh-completer-domain.c     |   57 +-
 tools/virsh-completer-snapshot.c   |    3 +-
 tools/virsh-domain-monitor.c       |  256 ++----
 tools/virsh-domain.c               | 1225 ++++++++++------------------
 tools/virsh-host.c                 |  212 ++---
 tools/virsh-interface.c            |   21 +-
 tools/virsh-network.c              |   24 +-
 tools/virsh-nodedev.c              |   27 +-
 tools/virsh-nwfilter.c             |   15 +-
 tools/virsh-pool.c                 |   34 +-
 tools/virsh-secret.c               |    9 +-
 tools/virsh-util.c                 |    3 +-
 tools/virsh-volume.c               |   35 +-
 tools/virsh.c                      |    3 +-
 tools/virt-admin.c                 |    6 +-
 tools/vsh.c                        |   11 +-
 18 files changed, 660 insertions(+), 1286 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/12] tools: virsh: use g_auto more (glib chronicles)
Posted by Martin Kletzander 2 years, 8 months ago
On Thu, Aug 12, 2021 at 10:32:38AM +0200, Ján Tomko wrote:
>Incomprehensive series removing many cleanup sections.
>
>Patch 1/12 is common with my other series:
>[libvirt PATCH 0/3] xml: use g_auto for xmlXPathObject
>
>Ján Tomko (12):
>  util: define cleanup func for xmlXPathObject
>  tools: virsh: split variable declarations
>  tools: virsh: cmdDominfo: rename 'ostype' variable
>  tools: virsh: use automatic cleanup for virDomainObj
>  tools: virsh: use automatic cleanup for xmlXPathContext
>  tools: virsh: use automatic cleanup for xmlXPathObject
>  tools: virsh: use automatic cleanup for xmlDoc
>  tools: virsh: use automatic cleanup for vshTable
>  tools: virsh: reduce variable scope to use automatic cleanup
>  tools: virsh: use automatic cleanup for char **
>  tools: virsh: use g_autofree
>  tools: virsh: remove redundant labels
>

with the 13/12 fixup for 12/12

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

The empty lines (see PATCH 12/12) are something I feel would make it
consistent with the rest of the code, but feel free to disagree.