virsh: moments: use g_auto more (glib chronicles)

[libvirt PATCH 00/10] virsh: moments: use g_auto more (glib chronicles)

Ján Tomko posted 10 patches 2 years, 8 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1628617414.git.jtomko@redhat.com

tools/virsh-checkpoint.c | 188 ++++++++-----------------
tools/virsh-snapshot.c   | 288 +++++++++++++--------------------------
tools/virsh-util.h       |   4 +
tools/vsh-table.h        |   1 +
4 files changed, 156 insertions(+), 325 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] virsh: moments: use g_auto more (glib chronicles)

Posted by Ján Tomko 2 years, 8 months ago

Ján Tomko (10):
  vsh: table: define cleanup function
  virsh: add cleanup function for virshDomainCheckpoint
  virsh: add cleanup function for virshDomainSnapshot
  virsh: checkpoint: move variables inside the loop
  virsh: snapshot: move variables inside the loop
  virsh: cmdCheckpointInfo: delete unused variables
  virsh: checkpoint: use g_auto where possible
  virsh: checkpoint: remove pointless cleanup labels
  virsh: snapshot: use g_auto where possible
  virsh: snapshot: remove pointless cleanup labels

 tools/virsh-checkpoint.c | 188 ++++++++-----------------
 tools/virsh-snapshot.c   | 288 +++++++++++++--------------------------
 tools/virsh-util.h       |   4 +
 tools/vsh-table.h        |   1 +
 4 files changed, 156 insertions(+), 325 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/10] virsh: moments: use g_auto more (glib chronicles)

Posted by Peter Krempa 2 years, 8 months ago

On Tue, Aug 10, 2021 at 19:44:59 +0200, Ján Tomko wrote:
> Ján Tomko (10):
>   vsh: table: define cleanup function
>   virsh: add cleanup function for virshDomainCheckpoint
>   virsh: add cleanup function for virshDomainSnapshot
>   virsh: checkpoint: move variables inside the loop
>   virsh: snapshot: move variables inside the loop
>   virsh: cmdCheckpointInfo: delete unused variables
>   virsh: checkpoint: use g_auto where possible
>   virsh: checkpoint: remove pointless cleanup labels
>   virsh: snapshot: use g_auto where possible
>   virsh: snapshot: remove pointless cleanup labels

Reviewed-by: Peter Krempa <pkrempa@redhat.com>