[v2] interface define: add support for validation against schema

[PATCH v2 0/4] interface define: add support for validation against schema

Kristina Hanicova posted 4 patches 2 years, 8 months ago

Diff against v1 v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1628259199.git.khanicov@redhat.com

docs/manpages/virsh.rst                 |  5 ++--
include/libvirt/libvirt-interface.h     |  4 +++
src/conf/interface_conf.c               | 38 ++++++++++++++++++-------
src/conf/interface_conf.h               |  6 ++--
src/conf/virinterfaceobj.c              |  2 +-
src/interface/interface_backend_netcf.c |  6 ++--
src/libvirt-interface.c                 |  2 +-
src/test/test_driver.c                  |  4 +--
tests/interfacexml2xmltest.c            |  2 +-
tools/virsh-interface.c                 | 10 ++++++-
10 files changed, 55 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH v2 0/4] interface define: add support for validation against schema

Posted by Kristina Hanicova 2 years, 8 months ago

This is v2 of:
https://listman.redhat.com/archives/libvir-list/2021-August/msg00187.html

Changes since v1 (suggested by Peter):
* split of the patch containing api and virsh adjustments into separate
  patches
* change of documentation (which I forgot to do before)

Kristina Hanicova (4):
  conf: propagate xmlDocPtr and flags into virInterfaceDefParseXML()
  api: add virInterfaceDefineFlags
  virsh: add support for '--validate' option in define interface
  interface_conf: add validation against schema in define

 docs/manpages/virsh.rst                 |  5 ++--
 include/libvirt/libvirt-interface.h     |  4 +++
 src/conf/interface_conf.c               | 38 ++++++++++++++++++-------
 src/conf/interface_conf.h               |  6 ++--
 src/conf/virinterfaceobj.c              |  2 +-
 src/interface/interface_backend_netcf.c |  6 ++--
 src/libvirt-interface.c                 |  2 +-
 src/test/test_driver.c                  |  4 +--
 tests/interfacexml2xmltest.c            |  2 +-
 tools/virsh-interface.c                 | 10 ++++++-
 10 files changed, 55 insertions(+), 24 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/4] interface define: add support for validation against schema

Posted by Kristina Hanicova 2 years, 8 months ago

On Fri, Aug 6, 2021 at 4:26 PM Kristina Hanicova <khanicov@redhat.com>
wrote:

> This is v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-August/msg00187.html
>
> Changes since v1 (suggested by Peter):
> * split of the patch containing api and virsh adjustments into separate
>   patches
> * change of documentation (which I forgot to do before)
>
> Kristina Hanicova (4):
>   conf: propagate xmlDocPtr and flags into virInterfaceDefParseXML()
>   api: add virInterfaceDefineFlags
>   virsh: add support for '--validate' option in define interface
>   interface_conf: add validation against schema in define
>
>  docs/manpages/virsh.rst                 |  5 ++--
>  include/libvirt/libvirt-interface.h     |  4 +++
>  src/conf/interface_conf.c               | 38 ++++++++++++++++++-------
>  src/conf/interface_conf.h               |  6 ++--
>  src/conf/virinterfaceobj.c              |  2 +-
>  src/interface/interface_backend_netcf.c |  6 ++--
>  src/libvirt-interface.c                 |  2 +-
>  src/test/test_driver.c                  |  4 +--
>  tests/interfacexml2xmltest.c            |  2 +-
>  tools/virsh-interface.c                 | 10 ++++++-
>  10 files changed, 55 insertions(+), 24 deletions(-)
>
> --
> 2.31.1
>
>
Hello,
please ignore this series, I came up with a better idea.
Will send patches soon.

Kristina

Re: [PATCH v2 0/4] interface define: add support for validation against schema

Posted by Jano Tomko 2 years, 8 months ago

On a %A in %Y, Kristina Hanicova wrote:
> On Fri, Aug 6, 2021 at 4:26 PM Kristina Hanicova <khanicov@redhat.com>
> wrote:
> 
>> This is v2 of:
>> https://listman.redhat.com/archives/libvir-list/2021-August/msg00187.html
>>
>> Changes since v1 (suggested by Peter):
>> * split of the patch containing api and virsh adjustments into separate
>>   patches
>> * change of documentation (which I forgot to do before)
>>
>> Kristina Hanicova (4):
>>   conf: propagate xmlDocPtr and flags into virInterfaceDefParseXML()
>>   api: add virInterfaceDefineFlags
>>   virsh: add support for '--validate' option in define interface
>>   interface_conf: add validation against schema in define
>>
>>  docs/manpages/virsh.rst                 |  5 ++--
>>  include/libvirt/libvirt-interface.h     |  4 +++
>>  src/conf/interface_conf.c               | 38 ++++++++++++++++++-------
>>  src/conf/interface_conf.h               |  6 ++--
>>  src/conf/virinterfaceobj.c              |  2 +-
>>  src/interface/interface_backend_netcf.c |  6 ++--
>>  src/libvirt-interface.c                 |  2 +-
>>  src/test/test_driver.c                  |  4 +--
>>  tests/interfacexml2xmltest.c            |  2 +-
>>  tools/virsh-interface.c                 | 10 ++++++-
>>  10 files changed, 55 insertions(+), 24 deletions(-)
>>
>> --
>> 2.31.1
>>
>>
> Hello,
> please ignore this series, I came up with a better idea.
> Will send patches soon.
> 
> Kristina
> 

Ignored-by: Ján Tomko <jtomko@redhat.com>

Jano