kill whole virtiofsd process group (virtio-fs epopee)

[libvirt PATCHv2 0/6] kill whole virtiofsd process group (virtio-fs epopee)

Ján Tomko posted 6 patches 2 years, 8 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1628003420.git.jtomko@redhat.com

src/libvirt_private.syms |  1 +
src/qemu/qemu_process.c  |  3 ++-
src/qemu/qemu_virtiofs.c |  2 +-
src/util/virpidfile.c    | 15 ++++++++++--
src/util/virpidfile.h    |  2 ++
src/util/virprocess.c    | 53 +++++++++++++++++++++++++++++++++++-----
src/util/virprocess.h    |  5 +++-
7 files changed, 70 insertions(+), 11 deletions(-)

Expand all Fold all

[libvirt PATCHv2 0/6] kill whole virtiofsd process group (virtio-fs epopee)

Posted by Ján Tomko 2 years, 8 months ago

v2 of:
https://listman.redhat.com/archives/libvir-list/2021-June/msg00570.html

Ján Tomko (6):
  virProcessKillPainfullyDelay: use 'rc' variable
  util: Introduce virProcessGroupKill
  util: introduce virProcessGroupGet
  util: virPidFileForceCleanupPath: add group argument
  qemu: virtiofs: kill the whole process group
  util: fix typo

 src/libvirt_private.syms |  1 +
 src/qemu/qemu_process.c  |  3 ++-
 src/qemu/qemu_virtiofs.c |  2 +-
 src/util/virpidfile.c    | 15 ++++++++++--
 src/util/virpidfile.h    |  2 ++
 src/util/virprocess.c    | 53 +++++++++++++++++++++++++++++++++++-----
 src/util/virprocess.h    |  5 +++-
 7 files changed, 70 insertions(+), 11 deletions(-)

-- 
2.31.1

Re: [libvirt PATCHv2 0/6] kill whole virtiofsd process group (virtio-fs epopee)

Posted by Michal Prívozník 2 years, 8 months ago

On 8/3/21 5:13 PM, Ján Tomko wrote:
> v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-June/msg00570.html
> 
> Ján Tomko (6):
>   virProcessKillPainfullyDelay: use 'rc' variable
>   util: Introduce virProcessGroupKill
>   util: introduce virProcessGroupGet
>   util: virPidFileForceCleanupPath: add group argument
>   qemu: virtiofs: kill the whole process group
>   util: fix typo
> 
>  src/libvirt_private.syms |  1 +
>  src/qemu/qemu_process.c  |  3 ++-
>  src/qemu/qemu_virtiofs.c |  2 +-
>  src/util/virpidfile.c    | 15 ++++++++++--
>  src/util/virpidfile.h    |  2 ++
>  src/util/virprocess.c    | 53 +++++++++++++++++++++++++++++++++++-----
>  src/util/virprocess.h    |  5 +++-
>  7 files changed, 70 insertions(+), 11 deletions(-)
> 

I think you split code into too many patches. If you squash some
together you have my:

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal