Add support for 'id' attribute for 'cachetune'

[PATCH v2 0/2] Add support for 'id' attribute for 'cachetune'

Kristina Hanicova posted 2 patches 2 years, 9 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1626785302.git.khanicov@redhat.com

docs/formatdomain.rst                     |  1 +
docs/schemas/domaincommon.rng             |  5 ++++
tests/genericxml2xmlindata/cachetune.xml  |  8 +++---
tests/genericxml2xmloutdata/cachetune.xml | 34 -----------------------
tests/genericxml2xmltest.c                |  2 +-
5 files changed, 11 insertions(+), 39 deletions(-)
delete mode 100644 tests/genericxml2xmloutdata/cachetune.xml

Expand all Fold all

[PATCH v2 0/2] Add support for 'id' attribute for 'cachetune'

Posted by Kristina Hanicova 2 years, 9 months ago

This is v2 of:
https://listman.redhat.com/archives/libvir-list/2021-July/msg00441.html

Changes since v1 (suggested by Michal):
* slight change of documentation
* improved commit message

Kristina Hanicova (2):
  docs: Allow 'id' attribute for 'cachetune' element
  genericxml2xmltest: Modify cachetune test to include id

 docs/formatdomain.rst                     |  1 +
 docs/schemas/domaincommon.rng             |  5 ++++
 tests/genericxml2xmlindata/cachetune.xml  |  8 +++---
 tests/genericxml2xmloutdata/cachetune.xml | 34 -----------------------
 tests/genericxml2xmltest.c                |  2 +-
 5 files changed, 11 insertions(+), 39 deletions(-)
 delete mode 100644 tests/genericxml2xmloutdata/cachetune.xml

-- 
2.31.1

Re: [PATCH v2 0/2] Add support for 'id' attribute for 'cachetune'

Posted by Michal Prívozník 2 years, 9 months ago

On 7/20/21 2:58 PM, Kristina Hanicova wrote:
> This is v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00441.html
> 
> Changes since v1 (suggested by Michal):
> * slight change of documentation
> * improved commit message
> 
> Kristina Hanicova (2):
>   docs: Allow 'id' attribute for 'cachetune' element
>   genericxml2xmltest: Modify cachetune test to include id
> 
>  docs/formatdomain.rst                     |  1 +
>  docs/schemas/domaincommon.rng             |  5 ++++
>  tests/genericxml2xmlindata/cachetune.xml  |  8 +++---
>  tests/genericxml2xmloutdata/cachetune.xml | 34 -----------------------
>  tests/genericxml2xmltest.c                |  2 +-
>  5 files changed, 11 insertions(+), 39 deletions(-)
>  delete mode 100644 tests/genericxml2xmloutdata/cachetune.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal