virsh: avoid local enum helpers with 'vir' prefix

[PATCH 0/5] virsh: avoid local enum helpers with 'vir' prefix

Peter Krempa posted 5 patches 2 years, 9 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1626695187.git.pkrempa@redhat.com

build-aux/syntax-check.mk      |  7 +++++++
tools/virsh-completer-domain.c |  8 ++++----
tools/virsh-completer-host.c   |  2 +-
tools/virsh-domain.c           | 18 +++++++++---------
tools/virsh-domain.h           |  8 ++++----
tools/virsh-host.c             |  4 ++--
tools/virsh-host.h             |  2 +-
tools/virsh-network.c          | 12 ++++++------
tools/virsh-volume.c           |  6 +++---
9 files changed, 37 insertions(+), 30 deletions(-)

Expand all Fold all

[PATCH 0/5] virsh: avoid local enum helpers with 'vir' prefix

Posted by Peter Krempa 2 years, 9 months ago

Follow up to:

https://listman.redhat.com/archives/libvir-list/2021-July/msg00281.html

Peter Krempa (5):
  virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers
  virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM*
    helpers
  virsh-network: Avoid 'vir' prefix for locally declared VIR_ENUM*
    helpers
  virsh-volume: Avoid 'vir' prefix for locally declared VIR_ENUM*
    helpers
  syntax-check: Prohibit 'vir' prefix for enum implementations in virsh

 build-aux/syntax-check.mk      |  7 +++++++
 tools/virsh-completer-domain.c |  8 ++++----
 tools/virsh-completer-host.c   |  2 +-
 tools/virsh-domain.c           | 18 +++++++++---------
 tools/virsh-domain.h           |  8 ++++----
 tools/virsh-host.c             |  4 ++--
 tools/virsh-host.h             |  2 +-
 tools/virsh-network.c          | 12 ++++++------
 tools/virsh-volume.c           |  6 +++---
 9 files changed, 37 insertions(+), 30 deletions(-)

-- 
2.31.1

Re: [PATCH 0/5] virsh: avoid local enum helpers with 'vir' prefix

Posted by Jano Tomko 2 years, 9 months ago

On a %A in %Y, Peter Krempa wrote:
> Follow up to:
> 
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00281.html
> 
> Peter Krempa (5):
>   virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers
>   virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM*
>     helpers
>   virsh-network: Avoid 'vir' prefix for locally declared VIR_ENUM*
>     helpers
>   virsh-volume: Avoid 'vir' prefix for locally declared VIR_ENUM*
>     helpers
>   syntax-check: Prohibit 'vir' prefix for enum implementations in virsh
> 
>  build-aux/syntax-check.mk      |  7 +++++++
>  tools/virsh-completer-domain.c |  8 ++++----
>  tools/virsh-completer-host.c   |  2 +-
>  tools/virsh-domain.c           | 18 +++++++++---------
>  tools/virsh-domain.h           |  8 ++++----
>  tools/virsh-host.c             |  4 ++--
>  tools/virsh-host.h             |  2 +-
>  tools/virsh-network.c          | 12 ++++++------
>  tools/virsh-volume.c           |  6 +++---
>  9 files changed, 37 insertions(+), 30 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano