storage_backend_iscsi_direct: Refactor string list use and cleanup

[PATCH 0/4] storage_backend_iscsi_direct: Refactor string list use and cleanup

Peter Krempa posted 4 patches 2 years, 10 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1624021457.git.pkrempa@redhat.com

src/conf/storage_conf.c                    | 16 ++++
src/conf/storage_conf.h                    |  5 ++
src/libvirt_private.syms                   |  1 +
src/storage/storage_backend_iscsi_direct.c | 87 +++++++++-------------
4 files changed, 56 insertions(+), 53 deletions(-)

Expand all Fold all

[PATCH 0/4] storage_backend_iscsi_direct: Refactor string list use and cleanup

Posted by Peter Krempa 2 years, 10 months ago

Peter Krempa (4):
  conf: storage: Introduce virStoragePoolSourceListFree
  virStorageBackendISCSIDirectFindPoolSources: Use allocated
    virStoragePoolSourceList
  virISCSIDirectUpdateTargets: Rework to simplify cleanup and return
    GStrv
  virStorageBackendISCSIDirectFindPoolSources: Rework cleanup

 src/conf/storage_conf.c                    | 16 ++++
 src/conf/storage_conf.h                    |  5 ++
 src/libvirt_private.syms                   |  1 +
 src/storage/storage_backend_iscsi_direct.c | 87 +++++++++-------------
 4 files changed, 56 insertions(+), 53 deletions(-)

-- 
2.31.1

Re: [PATCH 0/4] storage_backend_iscsi_direct: Refactor string list use and cleanup

Posted by Jano Tomko 2 years, 10 months ago

On 6/18/21 3:04 PM, Peter Krempa wrote:
> Peter Krempa (4):
>   conf: storage: Introduce virStoragePoolSourceListFree
>   virStorageBackendISCSIDirectFindPoolSources: Use allocated
>     virStoragePoolSourceList
>   virISCSIDirectUpdateTargets: Rework to simplify cleanup and return
>     GStrv
>   virStorageBackendISCSIDirectFindPoolSources: Rework cleanup
> 
>  src/conf/storage_conf.c                    | 16 ++++
>  src/conf/storage_conf.h                    |  5 ++
>  src/libvirt_private.syms                   |  1 +
>  src/storage/storage_backend_iscsi_direct.c | 87 +++++++++-------------
>  4 files changed, 56 insertions(+), 53 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano