qemu: snapshot: Fix removal of output files on failure

[PATCH 0/7] qemu: snapshot: Fix removal of output files on failure

Peter Krempa posted 7 patches 2 years, 10 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1623855902.git.pkrempa@redhat.com

src/conf/snapshot_conf.c | 10 +++----
src/conf/snapshot_conf.h |  2 +-
src/qemu/qemu_snapshot.c | 56 +++++++++++++++++++++++++++++-----------
3 files changed, 47 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/7] qemu: snapshot: Fix removal of output files on failure

Posted by Peter Krempa 2 years, 10 months ago

Peter Krempa (7):
  qemuSnapshotPrepareDiskExternal: Move temp variables into the block
    using them
  qemuSnapshotPrepareDiskExternal: Avoid condition squashing
  qemuSnapshotPrepareDiskExternal: Reject creation of block devices
    sooner
  qemuSnapshotPrepareDiskExternal: Enforce match between snapshot type
    and existing file type
  qemuSnapshotPrepareDiskExternal: Refactor existing file check
  conf: snapshot: rename variable holding memory snapshot file location
  qemuSnapshotCreateActiveExternal: Don't unlink memory snapshot image
    if it was existing before

 src/conf/snapshot_conf.c | 10 +++----
 src/conf/snapshot_conf.h |  2 +-
 src/qemu/qemu_snapshot.c | 56 +++++++++++++++++++++++++++++-----------
 3 files changed, 47 insertions(+), 21 deletions(-)

-- 
2.31.1

Re: [PATCH 0/7] qemu: snapshot: Fix removal of output files on failure

Posted by Jano Tomko 2 years, 10 months ago

On 6/16/21 5:05 PM, Peter Krempa wrote:
> Peter Krempa (7):
>   qemuSnapshotPrepareDiskExternal: Move temp variables into the block
>     using them
>   qemuSnapshotPrepareDiskExternal: Avoid condition squashing
>   qemuSnapshotPrepareDiskExternal: Reject creation of block devices
>     sooner
>   qemuSnapshotPrepareDiskExternal: Enforce match between snapshot type
>     and existing file type
>   qemuSnapshotPrepareDiskExternal: Refactor existing file check
>   conf: snapshot: rename variable holding memory snapshot file location
>   qemuSnapshotCreateActiveExternal: Don't unlink memory snapshot image
>     if it was existing before
> 
>  src/conf/snapshot_conf.c | 10 +++----
>  src/conf/snapshot_conf.h |  2 +-
>  src/qemu/qemu_snapshot.c | 56 +++++++++++++++++++++++++++++-----------
>  3 files changed, 47 insertions(+), 21 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano