String list handling cleanup in qemu capabilities code

[PATCH 00/13] String list handling cleanup in qemu capabilities code

Posted by Peter Krempa 2 years, 10 months ago

Peter Krempa (13):
  qemuMonitorJSONParsePropsList: Refactor cleanup
  qemuMonitorJSONGetObjectProps: Refactor cleanup
  qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup
  qemuMonitorJSONGetCommands: Refactor cleanup
  qemuMonitorJSONGetStringArray: Refactor cleanup
  qemuMonitorJSONGetObjectTypes: Refactor cleanup
  testQemuMonitorJSONGetCommands: Refactor cleanup
  testQemuMonitorJSONGetTPMModels: Refactor cleanup
  qemu: capabilities: Use g_auto(GStrv) instead of
    virStringListFreeCount
  virQEMUCapsProcessStringFlags: Don't require 'nvalues'
  virQEMUCapsProbeQMPTPM: Refactor handling of string lists
  qemuMonitorJSONGetStringArray: Don't return element count
  qemuMonitorJSONGetStringListProperty: Don't return element count

 src/qemu/qemu_capabilities.c |  82 ++++++++-------------
 src/qemu/qemu_monitor_json.c | 138 ++++++++++++-----------------------
 tests/qemumonitorjsontest.c  |  46 ++++--------
 3 files changed, 96 insertions(+), 170 deletions(-)

-- 
2.31.1

Re: [PATCH 00/13] String list handling cleanup in qemu capabilities code

Posted by Jano Tomko 2 years, 10 months ago

On 6/15/21 12:27 PM, Peter Krempa wrote:
> Peter Krempa (13):
>   qemuMonitorJSONParsePropsList: Refactor cleanup
>   qemuMonitorJSONGetObjectProps: Refactor cleanup
>   qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup
>   qemuMonitorJSONGetCommands: Refactor cleanup
>   qemuMonitorJSONGetStringArray: Refactor cleanup
>   qemuMonitorJSONGetObjectTypes: Refactor cleanup
>   testQemuMonitorJSONGetCommands: Refactor cleanup
>   testQemuMonitorJSONGetTPMModels: Refactor cleanup
>   qemu: capabilities: Use g_auto(GStrv) instead of
>     virStringListFreeCount
>   virQEMUCapsProcessStringFlags: Don't require 'nvalues'
>   virQEMUCapsProbeQMPTPM: Refactor handling of string lists
>   qemuMonitorJSONGetStringArray: Don't return element count
>   qemuMonitorJSONGetStringListProperty: Don't return element count
> 
>  src/qemu/qemu_capabilities.c |  82 ++++++++-------------
>  src/qemu/qemu_monitor_json.c | 138 ++++++++++++-----------------------
>  tests/qemumonitorjsontest.c  |  46 ++++--------
>  3 files changed, 96 insertions(+), 170 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano