[PATCH 0/7] qemu: Rework qemuBuildDeviceVideoStr() slightly

Michal Privoznik posted 7 patches 2 years, 10 months ago
Failed in applying to current master (apply log)
src/qemu/qemu_command.c | 159 +++++++++++++++++++++++++---------------
src/qemu/qemu_domain.c  |   2 +-
src/qemu/qemu_domain.h  |   2 +-
3 files changed, 102 insertions(+), 61 deletions(-)
[PATCH 0/7] qemu: Rework qemuBuildDeviceVideoStr() slightly
Posted by Michal Privoznik 2 years, 10 months ago
The most important patch is 7/7, IMO. The rest is just prep work.

Michal Prívozník (7):
  qemuDomainSupportsVideoVga: Fix const correctness
  qemuBuildDeviceVideoStr: Separate out video module selection
  qemuDeviceVideoGetModel: Deduplicate a check
  qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideo) to explicit
    switch()
  qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideoSecondary) to
    explicit switch()
  qemuBuildDeviceVideoStr: Move logic wrapping qemuBuildVirtioDevStr()
    into qemuDeviceVideoGetModel()
  qemuBuildDeviceVideoStr: Don't overwrite @model

 src/qemu/qemu_command.c | 159 +++++++++++++++++++++++++---------------
 src/qemu/qemu_domain.c  |   2 +-
 src/qemu/qemu_domain.h  |   2 +-
 3 files changed, 102 insertions(+), 61 deletions(-)

-- 
2.31.1

Re: [PATCH 0/7] qemu: Rework qemuBuildDeviceVideoStr() slightly
Posted by Peter Krempa 2 years, 10 months ago
On Fri, Jun 11, 2021 at 17:04:53 +0200, Michal Privoznik wrote:
> The most important patch is 7/7, IMO. The rest is just prep work.
> 
> Michal Prívozník (7):
>   qemuDomainSupportsVideoVga: Fix const correctness
>   qemuBuildDeviceVideoStr: Separate out video module selection
>   qemuDeviceVideoGetModel: Deduplicate a check
>   qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideo) to explicit
>     switch()
>   qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideoSecondary) to
>     explicit switch()
>   qemuBuildDeviceVideoStr: Move logic wrapping qemuBuildVirtioDevStr()
>     into qemuDeviceVideoGetModel()
>   qemuBuildDeviceVideoStr: Don't overwrite @model
> 
>  src/qemu/qemu_command.c | 159 +++++++++++++++++++++++++---------------
>  src/qemu/qemu_domain.c  |   2 +-
>  src/qemu/qemu_domain.h  |   2 +-
>  3 files changed, 102 insertions(+), 61 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>