virth-host-validate: Couple of cleanups

[PATCH 0/5] virth-host-validate: Couple of cleanups

Posted by Michal Privoznik 2 years, 10 months ago

I've noticed couple of bugs/problems while reviewing Fabiano's patch.
Here are fixes.

Michal Prívozník (5):
  virt-host-validate: Initialize the error object
  virt-host-validate: Report an error if failed to detect CGroups
  virt-host-validate: Turn failure to read /proc/cmdline into an error
  virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently
  virHostValidateSecureGuests: Drop useless 'return 0' at the end

 tools/virt-host-validate-common.c | 28 +++++++++++++++-------------
 tools/virt-host-validate.c        |  6 +++++-
 2 files changed, 20 insertions(+), 14 deletions(-)

-- 
2.31.1

Re: [PATCH 0/5] virth-host-validate: Couple of cleanups

Posted by Fabiano Fidêncio 2 years, 10 months ago

On Tue, Jun 8, 2021 at 10:45 AM Michal Privoznik <mprivozn@redhat.com> wrote:
>
> I've noticed couple of bugs/problems while reviewing Fabiano's patch.
> Here are fixes.
>
> Michal Prívozník (5):
>   virt-host-validate: Initialize the error object
>   virt-host-validate: Report an error if failed to detect CGroups
>   virt-host-validate: Turn failure to read /proc/cmdline into an error
>   virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently
>   virHostValidateSecureGuests: Drop useless 'return 0' at the end
>
>  tools/virt-host-validate-common.c | 28 +++++++++++++++-------------
>  tools/virt-host-validate.c        |  6 +++++-
>  2 files changed, 20 insertions(+), 14 deletions(-)
>
> --
> 2.31.1
>
Series:

Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
-- 
Fabiano Fidêncio

Re: [PATCH 0/5] virth-host-validate: Couple of cleanups

Posted by Fabiano Fidêncio 2 years, 10 months ago

On Tue, Jun 8, 2021 at 9:17 PM Fabiano Fidêncio <fabiano@fidencio.org> wrote:
>
> On Tue, Jun 8, 2021 at 10:45 AM Michal Privoznik <mprivozn@redhat.com> wrote:
> >
> > I've noticed couple of bugs/problems while reviewing Fabiano's patch.
> > Here are fixes.
> >
> > Michal Prívozník (5):
> >   virt-host-validate: Initialize the error object
> >   virt-host-validate: Report an error if failed to detect CGroups
> >   virt-host-validate: Turn failure to read /proc/cmdline into an error
> >   virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently
> >   virHostValidateSecureGuests: Drop useless 'return 0' at the end
> >
> >  tools/virt-host-validate-common.c | 28 +++++++++++++++-------------
> >  tools/virt-host-validate.c        |  6 +++++-
> >  2 files changed, 20 insertions(+), 14 deletions(-)
> >
> > --
> > 2.31.1
> >
> Series:
>
> Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
> --
> Fabiano Fidêncio

And while I have your attention, please, also consider:
https://listman.redhat.com/archives/libvir-list/2021-June/msg00214.html
I wrote that one as a follow-up to your series as it was just easier, sorry.

Best Regards,
-- 
Fabiano Fidêncio

Re: [PATCH 0/5] virth-host-validate: Couple of cleanups

Posted by Jano Tomko 2 years, 10 months ago

On 6/8/21 10:45 AM, Michal Privoznik wrote:
> I've noticed couple of bugs/problems while reviewing Fabiano's patch.
> Here are fixes.
> 
> Michal Prívozník (5):
>   virt-host-validate: Initialize the error object
>   virt-host-validate: Report an error if failed to detect CGroups
>   virt-host-validate: Turn failure to read /proc/cmdline into an error
>   virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently
>   virHostValidateSecureGuests: Drop useless 'return 0' at the end
> 
>  tools/virt-host-validate-common.c | 28 +++++++++++++++-------------
>  tools/virt-host-validate.c        |  6 +++++-
>  2 files changed, 20 insertions(+), 14 deletions(-)
> 

Series:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano