[PATCH RESEND v3 7/8] meson: optional_programs should be used only for building libvirt

Pavel Hrdina posted 8 patches 4 years, 8 months ago
[PATCH RESEND v3 7/8] meson: optional_programs should be used only for building libvirt
Posted by Pavel Hrdina 4 years, 8 months ago
Drop code that creates defines with program paths and update the comment
to reflect current usage of optional_programs.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 meson.build | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/meson.build b/meson.build
index 8e8d31953d..1c0de2f408 100644
--- a/meson.build
+++ b/meson.build
@@ -819,7 +819,7 @@ foreach item : required_programs_groups
 endforeach
 
 
-# optional programs
+# optional programs used while building libvirt
 
 optional_programs = [
   'augparse',
@@ -830,14 +830,6 @@ optional_programs = [
 foreach name : optional_programs
   prog = find_program(name, required: false, dirs: libvirt_sbin_path)
   varname = name.underscorify()
-  if prog.found()
-    prog_path = prog.path()
-  else
-    prog_path = name
-  endif
-
-  conf.set_quoted(varname.to_upper(), prog_path)
-  conf.set_quoted('@0@_PATH'.format(varname.to_upper()), prog_path)
   set_variable('@0@_prog'.format(varname), prog)
 endforeach
 
-- 
2.31.1

Re: [PATCH RESEND v3 7/8] meson: optional_programs should be used only for building libvirt
Posted by Andrea Bolognani 4 years, 8 months ago
On Tue, May 25, 2021 at 10:00:46AM +0200, Pavel Hrdina wrote:
> Drop code that creates defines with program paths and update the comment
> to reflect current usage of optional_programs.
>
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  meson.build | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization