capabilities: Turn @cpus in _virCapsHostNUMACell into GArray

[PATCH 0/3] capabilities: Turn @cpus in _virCapsHostNUMACell into GArray

Michal Privoznik posted 3 patches 2 years, 11 months ago

Download series mbox

Test syntax-check failed

Failed in applying to current master (apply log)

src/conf/capabilities.c        | 145 +++++++++++++++++----------------
src/conf/capabilities.h        |  11 +--
src/libvirt_private.syms       |   2 +-
src/libxl/libxl_capabilities.c |  34 ++++----
src/test/test_driver.c         |  12 +--
tests/testutils.c              |  23 +++---
6 files changed, 121 insertions(+), 106 deletions(-)

Expand all Fold all

[PATCH 0/3] capabilities: Turn @cpus in _virCapsHostNUMACell into GArray

Posted by Michal Privoznik 2 years, 11 months ago

Honestly, I don't really like GArray-s. I find plain C arrays better
(smaller memory footprint, direct access to items, no obscure
 g_array_*() bugs, fewer lines of code, etc.). But I'm posting these to
stir discussion.

However, 1/3 is still proper patch worth merging.

Michal Prívozník (3):
  libxl: Break down an if() in libxlCapsInitNuma()
  capabilities: Turn @cpus in _virCapsHostNUMACell into GArray
  virCapabilitiesHostNUMAInitReal: Drop cleanup label

 src/conf/capabilities.c        | 145 +++++++++++++++++----------------
 src/conf/capabilities.h        |  11 +--
 src/libvirt_private.syms       |   2 +-
 src/libxl/libxl_capabilities.c |  34 ++++----
 src/test/test_driver.c         |  12 +--
 tests/testutils.c              |  23 +++---
 6 files changed, 121 insertions(+), 106 deletions(-)

-- 
2.26.3