[PATCH v2 00/19] Refactoring conf to use XPath

Kristina Hanicova posted 19 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1620127676.git.khanicov@redhat.com
src/conf/domain_conf.c | 1641 +++++++++++++++++-----------------------
1 file changed, 707 insertions(+), 934 deletions(-)

[PATCH v2 00/19] Refactoring conf to use XPath

Posted by Kristina Hanicova 2 weeks ago
This is v2 from
https://listman.redhat.com/archives/libvir-list/2021-April/msg00617.html

Changes since v1:
 - rebase to the lastest git master

This series reworks the outdated way of parsing XML to parsing by XPath,
which is more obvious and saves a few lines of code.

Kristina Hanicova (19):
  conf: Propagate xmlXPathContextPtr into
    virDomainHostdevSubsysUSBDefParseXML()
  Refactoring virDomainHostdevSubsysUSBDefParseXML() to use XPath
  conf: Propagate xmlXPathContextPtr into virDomainBlkioDeviceParseXML()
  Refactoring virDomainBlkioDeviceParseXML() to use XPath
  conf: Propagate xmlXPathContextPtr into
    virDomainHostdevSubsysPCIDefParseXML()
  Refactoring virDomainHostdevSubsysPCIDefParseXML() to use XPath
  conf: Propagate xmlXPathContextPtr into virDomainLeaseDefParseXML()
  Refactoring virDomainLeaseDefParseXML() to use XPath
  Refactoring virDomainFSDefParseXML() to use XPath
  Refactoring virDomainNetDefParseXML() to use XPath
  conf: Propagate xmlXPathContextPtr into
    virDomainChrDefParseTargetXML()
  Refactoring virDomainChrDefParseTargetXML() to use XPath
  Refactoring virDomainChrSourceDefParseXML() to use XPath
  Refactoring virDomainChrDefParseXML() to use XPath
  Refactoring virDomainSmartcardDefParseXML() to use XPath
  Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath
  conf: Propagate xmlXPathContextPtr into
    virDomainVideoDriverDefParseXML()
  Refactoring virDomainVideoDriverDefParseXML() to use XPath
  Refactoring virDomainVideoDefParseXML() to use XPath

 src/conf/domain_conf.c | 1641 +++++++++++++++++-----------------------
 1 file changed, 707 insertions(+), 934 deletions(-)

-- 
2.30.2

Re: [PATCH v2 00/19] Refactoring conf to use XPath

Posted by Michal Prívozník 1 week, 6 days ago
On 5/4/21 1:39 PM, Kristina Hanicova wrote:
> This is v2 from
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00617.html
> 
> Changes since v1:
>  - rebase to the lastest git master
> 
> This series reworks the outdated way of parsing XML to parsing by XPath,
> which is more obvious and saves a few lines of code.
> 
> Kristina Hanicova (19):
>   conf: Propagate xmlXPathContextPtr into
>     virDomainHostdevSubsysUSBDefParseXML()
>   Refactoring virDomainHostdevSubsysUSBDefParseXML() to use XPath
>   conf: Propagate xmlXPathContextPtr into virDomainBlkioDeviceParseXML()
>   Refactoring virDomainBlkioDeviceParseXML() to use XPath
>   conf: Propagate xmlXPathContextPtr into
>     virDomainHostdevSubsysPCIDefParseXML()
>   Refactoring virDomainHostdevSubsysPCIDefParseXML() to use XPath
>   conf: Propagate xmlXPathContextPtr into virDomainLeaseDefParseXML()
>   Refactoring virDomainLeaseDefParseXML() to use XPath
>   Refactoring virDomainFSDefParseXML() to use XPath
>   Refactoring virDomainNetDefParseXML() to use XPath
>   conf: Propagate xmlXPathContextPtr into
>     virDomainChrDefParseTargetXML()
>   Refactoring virDomainChrDefParseTargetXML() to use XPath
>   Refactoring virDomainChrSourceDefParseXML() to use XPath
>   Refactoring virDomainChrDefParseXML() to use XPath
>   Refactoring virDomainSmartcardDefParseXML() to use XPath
>   Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath
>   conf: Propagate xmlXPathContextPtr into
>     virDomainVideoDriverDefParseXML()
>   Refactoring virDomainVideoDriverDefParseXML() to use XPath
>   Refactoring virDomainVideoDefParseXML() to use XPath
> 
>  src/conf/domain_conf.c | 1641 +++++++++++++++++-----------------------
>  1 file changed, 707 insertions(+), 934 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal