[libvirt PATCH v2 1/6] ci: Makefile: Specify a help target to replace ci-help

Erik Skultety posted 6 patches 4 years, 10 months ago
There is a newer version of this series
[libvirt PATCH v2 1/6] ci: Makefile: Specify a help target to replace ci-help
Posted by Erik Skultety 4 years, 10 months ago
It's quite pointless to have a 'ci-help' target in the Makefile when
one needs to actually open the Makefile to go through the list of
targets to know what functionality the Makefile actually provides. It's
much more intuitive to run "make help" in that case. Therefore, add a
'help' target and replace the old 'ci-help' target with it.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---
 ci/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ci/Makefile b/ci/Makefile
index 72f5bda942..f83ecac1e5 100644
--- a/ci/Makefile
+++ b/ci/Makefile
@@ -222,7 +222,7 @@ ci-list-images:
 	@sh list-images.sh "$(CI_IMAGE_PREFIX)" | grep cross
 	@echo
 
-ci-help:
+help:
 	@echo
 	@echo
 	@echo
@@ -242,7 +242,7 @@ ci-help:
 	@echo "    ci-test@\$$IMAGE  - run a 'ninja test'"
 	@echo "    ci-shell@\$$IMAGE - run an interactive shell"
 	@echo "    ci-list-images  - list available images"
-	@echo "    ci-help         - show this help message"
+	@echo "    help            - show this help message"
 	@echo
 	@echo "Available make variables:"
 	@echo
-- 
2.29.2

Re: [libvirt PATCH v2 1/6] ci: Makefile: Specify a help target to replace ci-help
Posted by Andrea Bolognani 4 years, 10 months ago
On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
> It's quite pointless to have a 'ci-help' target in the Makefile when
> one needs to actually open the Makefile to go through the list of
> targets to know what functionality the Makefile actually provides. It's
> much more intuitive to run "make help" in that case. Therefore, add a
> 'help' target and replace the old 'ci-help' target with it.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  ci/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Since we now expect users to call the ci/helper script rather than
using ci/Makefile directly, this is unnecessary. Please drop it from
the series.

-- 
Andrea Bolognani / Red Hat / Virtualization