[v2] Fix calling of virNetworkUpdate() driver callback

[PATCH v2 0/2] Fix calling of virNetworkUpdate() driver callback

Michal Privoznik posted 2 patches 3 years, 1 month ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1615894911.git.mprivozn@redhat.com

src/esx/esx_driver.c                |  3 +++
src/libvirt-network.c               | 24 ++++++++++++++++++++--
src/libvirt_internal.h              |  5 +++++
src/libxl/libxl_driver.c            |  1 +
src/lxc/lxc_driver.c                |  1 +
src/network/bridge_driver.c         | 32 +++++++++++++++++++++++++++++
src/openvz/openvz_driver.c          |  1 +
src/qemu/qemu_driver.c              |  1 +
src/remote/remote_daemon_dispatch.c |  1 +
src/test/test_driver.c              |  1 +
10 files changed, 68 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Fix calling of virNetworkUpdate() driver callback

Posted by Michal Privoznik 3 years, 1 month ago

v2 of:

https://listman.redhat.com/archives/libvir-list/2021-March/msg00052.html

I've pushed 1/2 from the v1 series (which just debug printed all
arguments) which is unrelated to this problem.

diff to v1:
- Implemented different approach as suggested by Jano in his review of
  v1. I must say I like it more.

Michal Prívozník (2):
  network: Implement virConnectSupportsFeature()
  lib: Fix calling of virNetworkUpdate() driver callback

 src/esx/esx_driver.c                |  3 +++
 src/libvirt-network.c               | 24 ++++++++++++++++++++--
 src/libvirt_internal.h              |  5 +++++
 src/libxl/libxl_driver.c            |  1 +
 src/lxc/lxc_driver.c                |  1 +
 src/network/bridge_driver.c         | 32 +++++++++++++++++++++++++++++
 src/openvz/openvz_driver.c          |  1 +
 src/qemu/qemu_driver.c              |  1 +
 src/remote/remote_daemon_dispatch.c |  1 +
 src/test/test_driver.c              |  1 +
 10 files changed, 68 insertions(+), 2 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/2] Fix calling of virNetworkUpdate() driver callback

Posted by Martin Kletzander 3 years ago

On Tue, Mar 16, 2021 at 12:44:04PM +0100, Michal Privoznik wrote:
>v2 of:
>
>https://listman.redhat.com/archives/libvir-list/2021-March/msg00052.html
>
>I've pushed 1/2 from the v1 series (which just debug printed all
>arguments) which is unrelated to this problem.
>
>diff to v1:
>- Implemented different approach as suggested by Jano in his review of
>  v1. I must say I like it more.
>
>Michal Prívozník (2):
>  network: Implement virConnectSupportsFeature()
>  lib: Fix calling of virNetworkUpdate() driver callback

Terrifying, but makes sense.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>
> src/esx/esx_driver.c                |  3 +++
> src/libvirt-network.c               | 24 ++++++++++++++++++++--
> src/libvirt_internal.h              |  5 +++++
> src/libxl/libxl_driver.c            |  1 +
> src/lxc/lxc_driver.c                |  1 +
> src/network/bridge_driver.c         | 32 +++++++++++++++++++++++++++++
> src/openvz/openvz_driver.c          |  1 +
> src/qemu/qemu_driver.c              |  1 +
> src/remote/remote_daemon_dispatch.c |  1 +
> src/test/test_driver.c              |  1 +
> 10 files changed, 68 insertions(+), 2 deletions(-)
>
>-- 
>2.26.2
>