Refactoring node_device_conf

[PATCH 0/4] Refactoring node_device_conf

Kristina Hanicova posted 4 patches 3 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1614788020.git.khanicov@redhat.com

src/conf/node_device_conf.c | 324 +++++++++++++-----------------------
1 file changed, 118 insertions(+), 206 deletions(-)

Expand all Fold all

[PATCH 0/4] Refactoring node_device_conf

Posted by Kristina Hanicova 3 years, 1 month ago

This refactors file node_device_conf in order to remove VIR_FREE
(if possible) and removes redundant variables and labels.

Kristina Hanicova (4):
  node_device_conf: Use g_autofree where possible
  node_device_conf: Refactoring functions in order to remove VIR_FREE
  node_device_conf: use g_autoptr in
    virNodeDevCapPCIDevIommuGroupParseXML()
  node_device_conf: Remove redundant variables/labels

 src/conf/node_device_conf.c | 324 +++++++++++++-----------------------
 1 file changed, 118 insertions(+), 206 deletions(-)

-- 
2.29.2

Re: [PATCH 0/4] Refactoring node_device_conf

Posted by Michal Privoznik 3 years, 1 month ago

On 3/3/21 5:17 PM, Kristina Hanicova wrote:
> This refactors file node_device_conf in order to remove VIR_FREE
> (if possible) and removes redundant variables and labels.
> 
> Kristina Hanicova (4):
>    node_device_conf: Use g_autofree where possible
>    node_device_conf: Refactoring functions in order to remove VIR_FREE
>    node_device_conf: use g_autoptr in
>      virNodeDevCapPCIDevIommuGroupParseXML()
>    node_device_conf: Remove redundant variables/labels
> 
>   src/conf/node_device_conf.c | 324 +++++++++++++-----------------------
>   1 file changed, 118 insertions(+), 206 deletions(-)
> 

I'm fixing the small nit in 3/4 and pushing.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal