cgroup cpu.shares cleanup

[libvirt PATCH 0/3] cgroup cpu.shares cleanup

Pavel Hrdina posted 3 patches 3 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1614778388.git.phrdina@redhat.com

docs/formatdomain.rst      |  3 ++-
docs/manpages/virsh.rst    |  5 +----
src/conf/domain_validate.c | 10 ++++++++++
src/libvirt_private.syms   |  1 -
src/lxc/lxc_cgroup.c       |  4 +---
src/lxc/lxc_driver.c       |  6 ++----
src/qemu/qemu_cgroup.c     | 21 +--------------------
src/qemu/qemu_driver.c     |  7 +++----
src/util/vircgroup.c       | 20 --------------------
src/util/vircgroup.h       |  4 ++--
src/util/vircgroupv1.c     | 10 ++++++++++
src/util/vircgroupv2.c     | 10 ++++++++++
12 files changed, 42 insertions(+), 59 deletions(-)

Expand all Fold all

[libvirt PATCH 0/3] cgroup cpu.shares cleanup

Posted by Pavel Hrdina 3 years, 1 month ago

After the conversion to using systemd DBus APIs the behavior of changed
for values outside of valid range. This series fixes the issue by
enforcing the range on libvirt side instead of the previous magic
conversion done by kernel.

Pavel Hrdina (3):
  vircgroup: enforce range limit for cpu.shares
  cgroup: use virCgroupSetCpuShares instead of virCgroupSetupCpuShares
  vircgroup: drop unused function virCgroupSetupCpuShares

 docs/formatdomain.rst      |  3 ++-
 docs/manpages/virsh.rst    |  5 +----
 src/conf/domain_validate.c | 10 ++++++++++
 src/libvirt_private.syms   |  1 -
 src/lxc/lxc_cgroup.c       |  4 +---
 src/lxc/lxc_driver.c       |  6 ++----
 src/qemu/qemu_cgroup.c     | 21 +--------------------
 src/qemu/qemu_driver.c     |  7 +++----
 src/util/vircgroup.c       | 20 --------------------
 src/util/vircgroup.h       |  4 ++--
 src/util/vircgroupv1.c     | 10 ++++++++++
 src/util/vircgroupv2.c     | 10 ++++++++++
 12 files changed, 42 insertions(+), 59 deletions(-)

-- 
2.29.2

Re: [libvirt PATCH 0/3] cgroup cpu.shares cleanup

Posted by Michal Privoznik 3 years, 1 month ago

On 3/3/21 2:35 PM, Pavel Hrdina wrote:
> After the conversion to using systemd DBus APIs the behavior of changed
> for values outside of valid range. This series fixes the issue by
> enforcing the range on libvirt side instead of the previous magic
> conversion done by kernel.
> 
> Pavel Hrdina (3):
>    vircgroup: enforce range limit for cpu.shares
>    cgroup: use virCgroupSetCpuShares instead of virCgroupSetupCpuShares
>    vircgroup: drop unused function virCgroupSetupCpuShares
> 
>   docs/formatdomain.rst      |  3 ++-
>   docs/manpages/virsh.rst    |  5 +----
>   src/conf/domain_validate.c | 10 ++++++++++
>   src/libvirt_private.syms   |  1 -
>   src/lxc/lxc_cgroup.c       |  4 +---
>   src/lxc/lxc_driver.c       |  6 ++----
>   src/qemu/qemu_cgroup.c     | 21 +--------------------
>   src/qemu/qemu_driver.c     |  7 +++----
>   src/util/vircgroup.c       | 20 --------------------
>   src/util/vircgroup.h       |  4 ++--
>   src/util/vircgroupv1.c     | 10 ++++++++++
>   src/util/vircgroupv2.c     | 10 ++++++++++
>   12 files changed, 42 insertions(+), 59 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal