[PATCH 1/4] qemu_tpm: Move logfile path generation into a separate function

Michal Privoznik posted 4 patches 4 years, 11 months ago
[PATCH 1/4] qemu_tpm: Move logfile path generation into a separate function
Posted by Michal Privoznik 4 years, 11 months ago
Strictly not needed, but the rest of paths is generated in
separate functions. Helps with code readability.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_tpm.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index f94cad8230..71339b785a 100644
--- a/src/qemu/qemu_tpm.c
+++ b/src/qemu/qemu_tpm.c
@@ -82,6 +82,21 @@ qemuTPMCreateEmulatorStoragePath(const char *swtpmStorageDir,
 }
 
 
+/**
+ * qemuTPMCreateEmulatorLogPath:
+ * @logDir: directory where swtpm writes its logs into
+ * @vmname: name of the VM
+ *
+ * Create the swtpm's log path.
+ */
+static char*
+qemuTPMCreateEmulatorLogPath(const char *logDir,
+                             const char *vmname)
+{
+    return g_strdup_printf("%s/%s-swtpm.log", logDir, vmname);
+}
+
+
 /*
  * qemuTPMEmulatorInitStorage
  *
@@ -286,7 +301,7 @@ qemuTPMEmulatorPrepareHost(virDomainTPMDefPtr tpm,
 
     /* create logfile name ... */
     if (!tpm->data.emulator.logfile)
-        tpm->data.emulator.logfile = g_strdup_printf("%s/%s-swtpm.log", logDir, vmname);
+        tpm->data.emulator.logfile = qemuTPMCreateEmulatorLogPath(logDir, vmname);
 
     if (!virFileExists(tpm->data.emulator.logfile) &&
         virFileTouch(tpm->data.emulator.logfile, 0644) < 0) {
-- 
2.26.2

Re: [PATCH 1/4] qemu_tpm: Move logfile path generation into a separate function
Posted by Ján Tomko 4 years, 11 months ago
On a Monday in 2021, Michal Privoznik wrote:
>Strictly not needed, but the rest of paths is generated in
>separate functions. Helps with code readability.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/qemu/qemu_tpm.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano